-
Notifications
You must be signed in to change notification settings - Fork 4
feat: capture page views and surface as page_events in selectPlacements #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
b6d0d75
docs: design spec for page-view capture into local session attributes
alexs-mparticle c97568c
docs: capture ActiveTimeOnSite, pageUrl, SourceMessageId, timestamp, …
alexs-mparticle d16c1ab
feat: surface captured page views as flat page_events in selectPlacem…
alexs-mparticle ba89396
feat: derive timeOnPage per entry in page_events
alexs-mparticle a62a003
Merge remote-tracking branch 'origin/development' into capture-page-v…
alexs-mparticle 59297d6
chore: revert dist to match development (CI-generated, not hand-autho…
alexs-mparticle a7fc33c
chore: drop design spec doc from PR
alexs-mparticle f0b4e89
refactor: trim redundant comments in page-view code
alexs-mparticle b8973ca
refactor: store page view event name as event_name at capture
alexs-mparticle 89353f8
Apply suggestion from @alexs-mparticle
alexs-mparticle 2ab8c00
refactor: type page_events explicitly and keep legacy tests on PageView
alexs-mparticle f24d719
refactor: address PR review — no store mutation, explicit names, hone…
alexs-mparticle d9b1654
refactor: drop unnecessary comments in page-view code
alexs-mparticle 2ff8907
Apply suggestion from @alexs-mparticle
alexs-mparticle efc2ce2
refactor: address PR review — persist page views as JSON, rename LS k…
alexs-mparticle db6c1bc
fix: strip query params from page URLs and address review nits
alexs-mparticle 7b5c33a
refactor: drop event_name and event attributes from page events
alexs-mparticle 9c7b27f
fix: stringify page_events before sending to selectPlacements
alexs-mparticle f12e8a8
refactor: capture page URL early and collapse page-view schema
alexs-mparticle 329efb3
fix: Remove isKitReady guard from process events function
alexs-mparticle 4c278f5
feat: cap page-view history by byte budget keyed to storage backend
alexs-mparticle 8cf350b
refactor: move page-view capture to kit-owned localStorage
alexs-mparticle 9fc8b0e
feat: clear kit-owned page views on session end
alexs-mparticle 9c340f1
fix: make PageEvent.activeTimeOnSite optional for storage round-trip
alexs-mparticle 799cbc5
fix: restore not-ready signal and gate page-view capture on targeting
alexs-mparticle ccdc2fa
fix: drop activeTimeOnSite guard and restore non-optional type
alexs-mparticle 2ca0366
fix: coerce non-finite ActiveTimeOnSite to 0 at write boundary
alexs-mparticle 7b1cf3b
fix: omit non-finite activeTimeOnSite and clear page views when targe…
alexs-mparticle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.