Skip to content

auth: Skip OIDC flow if Bearer access_token is present (bug 1979246) - #551

Open
shtrom wants to merge 3 commits into
mozilla:mainfrom
shtrom:bug1979246/access_token-bearer
Open

auth: Skip OIDC flow if Bearer access_token is present (bug 1979246)#551
shtrom wants to merge 3 commits into
mozilla:mainfrom
shtrom:bug1979246/access_token-bearer

Conversation

@shtrom

@shtrom shtrom commented Jul 25, 2025

Copy link
Copy Markdown
Member

No description provided.

@shtrom shtrom mentioned this pull request Aug 11, 2025
Merged
@shtrom
shtrom force-pushed the bug1979246/access_token-bearer branch 2 times, most recently from a082589 to 0c8105b Compare August 13, 2025 05:59
@shtrom
shtrom marked this pull request as ready for review August 13, 2025 06:13
@shtrom

shtrom commented Aug 13, 2025

Copy link
Copy Markdown
Member Author

E2E tests seem to fail due to a firefox (web?)driver missing.

@janbrasna

janbrasna commented Jan 24, 2026

Copy link
Copy Markdown
Contributor

(Yeah the CI is now updated) Would you mind rebasing that for fresh test runs @shtrom? TY!

@shtrom

shtrom commented Jan 26, 2026

Copy link
Copy Markdown
Member Author

Just rebased and pushed 🤞🏼

@shtrom
shtrom force-pushed the bug1979246/access_token-bearer branch 3 times, most recently from c306e03 to aa4a354 Compare January 29, 2026 01:03
@shtrom
shtrom force-pushed the bug1979246/access_token-bearer branch from aa4a354 to b97e088 Compare January 29, 2026 02:08
zzzeid
zzzeid reviewed Jan 29, 2026
View reviewed changes

@zzzeid zzzeid left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest putting this functionality in a separate backend that extends OIDCAuthenticationBackend. Something like OIDCTokenAuthenticationBackend.

@shtrom shtrom mentioned this pull request Jan 30, 2026
Closed
@shtrom
shtrom force-pushed the bug1979246/access_token-bearer branch from 08e8af5 to 334713c Compare February 4, 2026 03:25
@shtrom

shtrom commented Feb 4, 2026

Copy link
Copy Markdown
Member Author

I would suggest putting this functionality in a separate backend that extends OIDCAuthenticationBackend. Something like OIDCTokenAuthenticationBackend.

Ok, I did just that in the last commit I pushed!

This way both authentication methods can be selectively composed as needed in the standard Django fashion.

@shtrom

shtrom commented Feb 4, 2026

Copy link
Copy Markdown
Member Author

The PR title should probably be changed to something like

auth: add OIDCTokenAuthenticationBackend to authenticate requests based on Bearer access_token (bug 1979246)

But I don't have permissions to do so.

@shtrom
shtrom force-pushed the bug1979246/access_token-bearer branch from 9e3c0e8 to d6b3e22 Compare February 4, 2026 03:52
@shtrom
shtrom force-pushed the bug1979246/access_token-bearer branch from d6b3e22 to 0081ca4 Compare February 4, 2026 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@zzzeid zzzeid zzzeid left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shtrom @janbrasna @zzzeid