Update installation.rst to set LOGIN_URL - #469
Conversation
Setting LOGIN_URL enables django's login_required decorator to use mozilla-django-keycloak's login URL.
|
@ajcollins thank you for this PR! Could you maybe explain why this needs to be part of the documentation? Probably there is a typo here too as you mention |
|
@akatsoulas thank you for considering it and for the very helpful project. Sorry for the lack of clarity and typo. I proposed the change as, after following the mozilla_django_oidc installation instructions, views decorated with django's I realise that many will add OIDC support having already set I've fixed the typo and updated the comment in the code. Hopefully this improves the clarity. |
|
Thanks @ajcollins for clarifying this! |
| 'mozilla_django_oidc.auth.OIDCAuthenticationBackend', | ||
| # ... | ||
|
|
||
| # Set LOGIN_URL to mozilla_django_oidc's login URL. |
There was a problem hiding this comment.
@ajcollins can you maybe rephrase this a bit to indicate that is more of a hint and not a necessary step?
There was a problem hiding this comment.
@akatsoulas sorry for the delay. Good point. PR updated.
Update docs to set LOGIN_URL, which enables django's login_required decorator to use mozilla-django-keycloak's login URL.