feat(payments): Switch all Mozilla accounts legal links over to Mozilla.org version - #20911
feat(payments): Switch all Mozilla accounts legal links over to Mozilla.org version#20911elizabeth-ilina wants to merge 1 commit into
Conversation
2ee6138 to
d4d7181
Compare
d4d7181 to
f8ad3b6
Compare
835f21b to
d85ead3
Compare
925db37 to
10ff5f5
Compare
…la.org version Because: * We use Mozilla account links (e.g. https://accounts.firefox.com/legal/terms) throughout the repo. This commit: * Updates links for all accounts & subplat surfaces to point to current versions on http://mozilla.org. * Instead of downloadable PDFs for legal docs in SubPlat emails, replaces the links to download legal PDFs to the equivalent legal docs on http://mozilla.org (e.g., …/subscription_services_privacy_notice.pdf is replaced by https://www.mozilla.org/privacy/subscription-services/) * Retires https://github.com/mozilla/fxa/actions/workflows/pull-legal-docs.yml github action * Does NOT remove current Legal docs from the accounts CDN, since these need to stay in place for emails sent prior to this change to avoid broken URLs. Closes #[PAY-3829](https://mozilla-hub.atlassian.net/browse/PAY-3829)
10ff5f5 to
e860e37
Compare
| • | ||
|
|
||
| <a href="<%- subscriptionTermsUrl %>" class="footer-link" data-l10n-id="subplat-moz-terms">Mozilla Accounts Terms of Service</a> | ||
| <a href="https://www.mozilla.org/about/legal/terms/services/" class="footer-link" data-l10n-id="subplat-moz-terms">Mozilla Accounts Terms of Service</a> |
There was a problem hiding this comment.
question: why hardcode the value instead of using the variable?
There was a problem hiding this comment.
With regards to the FxA sign up email's Privacy link having query params but not Terms, this isn't related to these changes since this is currently the case on Stage as well:
Accounts Privacy notice is https://www.mozilla.org/privacy/mozilla-accounts/?utm_medium=email&utm_content=fx-privacy

And Accounts Terms of Service is https://www.mozilla.org/about/legal/terms/services/

About replacing the subscriptionTermsUrl with a hardcoded url - the display text for the link is "Mozilla Accounts Terms of Service", but subscriptionTermsUrl is a subscription services terms link (https://www.mozilla.org/about/legal/terms/subscription-services instead of https://www.mozilla.org/about/legal/terms/services/). The reason I made it a hardcoded url was because I couldn't find an appropriate existing Accounts Terms variable, and, I noticed that this url is being hardcoded in other similar places, such as L108 in the same file.
However, if using the subscriptionTermsUrl instead of the Accounts terms url was intentional in this case, please let me know and I'll revert the change!

Because
This pull request
Updates links for all accounts & subplat surfaces to point to current versions on http://mozilla.org.
Instead of downloadable PDFs for legal docs in SubPlat emails, replaces the links to download legal PDFs to the equivalent legal docs on http://mozilla.org (e.g., …/subscription_services_privacy_notice.pdf is replaced by https://www.mozilla.org/privacy/subscription-services/)
Retires https://github.com/mozilla/fxa/actions/workflows/pull-legal-docs.yml github action
Does NOT remove /legal/* routes or current Legal docs from the accounts CDN, since these need to stay in place for emails sent prior to this change to avoid broken URLs.
Fixed subplat-moz-terms link target in the subscription email footer: The subscription email layout footer rendered a link labeled "Mozilla Accounts Terms of Service" (subplat-moz-terms) using subscriptionTermsUrl instead of the accounts ToS. Now hardcoded to https://www.mozilla.org/about/legal/terms/services/, matching how the subplat-legal link in the same file and moz-accounts-terms-url in the fxa layout already do it.
FYI, a follow-up ticket was created to redirect ToS and Privacy Notice links hosted on firefox.com to mozilla.org.
UI Updates:
"Enter confirmation code" page, updated links to Terms of Service and Privacy Notice
/legal page:
Checkout, location, and upgrade pages:
SubPlat subscription emails:
Updated Strapi common content
* Mozilla VPN:
privacyNoticeUrl: from https://cdn.accounts.firefox.com/legal/privacy-notice.pdf to https://www.mozilla.org/privacy/subscription-services
termsOfServiceUrl: from https://cdn.accounts.firefox.com/legal/tos.html to https://www.mozilla.org/about/legal/terms/subscription-services
* 123 Foxkeh
* 123Done Pro
* 123Done Pro Plus
* Cooking with Foxkeh
* Cooking with Foxkeh 2
* Nothing yet, will update after merging
Issue that this pull request solves
Closes #PAY-3829
Checklist
Put an
xin the boxes that applyHow to review (Optional)
Screenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.