feat: Add note about JIT breaking sites / having perf impact - #250
Merged
Conversation
Collaborator
Author
|
Going to merge now, but just FYI these changes are live shortly @Mossop |
Member
|
I can't figure out how to actually review it now it has landed but r+ |
Collaborator
Author
The deployed page is here if you want to have a quick look: https://firefox-admin-docs.mozilla.org/reference/policies/sitepolicies/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Explain that disabling JIT can break sites, slow them down, and disables WASM.
Motivation:
Avoid cases where WASM breaks and users don't know why.
Related issues and pull requests:
Fixes #249