fix(auth): stop unhandled rejections from FxA sign-in#6765
Draft
groovecoder wants to merge 1 commit into
Draft
Conversation
signIn fetches and then redirects the page to FxA. When the browser aborts an in-flight fetch during that redirect, it rejects with a network TypeError. Every call site voided the promise, so the rejection surfaced as an unhandled rejection in Sentry. A shared signInToFxa wrapper catches the rejection. It drops the expected network TypeError and reports anything else as handled. Fixes MNTOR-3923
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
signInfetches and then redirects the page to FxA. When the browser aborts an in-flight fetch during that redirect, it rejects with a networkTypeError. Every call site voided the promise, so the rejection surfaced as an unhandled rejection in Sentry.A shared
signInToFxawrapper catches the rejection. It drops the expected networkTypeErrorand reports anything else as handled.References:
Jira: MNTOR-3923