fix(functional-tests): guard teardown against slow stage navigation#6754
Open
groovecoder wants to merge 1 commit into
Open
fix(functional-tests): guard teardown against slow stage navigation#6754groovecoder wants to merge 1 commit into
groovecoder wants to merge 1 commit into
Conversation
The "Delete test user accounts" teardown fails the same way across runs. Line 38 clicks "Open user menu" before the page settles, so a slow stage redirect detaches the frame. Line 55 waits for an exact /en URL, which aborts when the app lands on a path with a trailing segment. Wait for the menu button to be visible before clicking. Loosen the post-delete URL wait to match the /en prefix.
GregHilstonMozilla
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Delete test user accounts" teardown fails the same way across runs. Line 38 clicks "Open user menu" before the page settles, so a slow stage redirect detaches the frame. Line 55 waits for an exact /en URL, which aborts when the app lands on a path with a trailing segment.
Wait for the menu button to be visible before clicking. Loosen the post-delete URL wait to match the /en prefix.
Localization strings (if needed) have been added.I've added or updated the relevant sections in readme and/or code commentsI've added a unit test to test for potential regressions of this bug.If this PR implements a feature flag or experimentation, I've checked that it still works with the flag both on, and with the flag off.If this PR implements a feature flag or experimentation, the Ship Behind Feature Flag status in Jira has been setProduct Owner accepted the User Story (demo of functionality completed) or waived the privilege.All acceptance criteria are met.Jira ticket has been updated (if needed) to match changes made during the development process.Jira ticket has been updated (if needed) with suggestions for QA when this PR is deployed to stage.