Bug 2009746 - #2693
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes Bug 2009746 by preventing email-header injection through whine subjects.
Changes:
- Sanitizes subjects before storage and delivery.
- Builds headers through
Email::MIME->create. - Adds regression coverage for malicious subjects.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
whine.pl |
Safely constructs whine email headers. |
editwhines.cgi |
Sanitizes submitted subjects. |
template/en/default/whine/subject.txt.tmpl |
Renders subject values separately. |
template/en/default/whine/multipart-mime.txt.tmpl |
Removes raw MIME-header rendering. |
t/whine-subject-header-injection.t |
Tests header-injection defenses. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carried r+ over from private pull request
https://bugzilla.mozilla.org/show_bug.cgi?id=2009746