Skip to content

Bug 2055516 - #2692

Merged
dklawren merged 1 commit into
mozilla-bteam:masterfrom
dklawren:2055516
Aug 5, 2026
Merged

Bug 2055516#2692
dklawren merged 1 commit into
mozilla-bteam:masterfrom
dklawren:2055516

Conversation

@dklawren

@dklawren dklawren commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Carried of r+ from private pull request
https://bugzilla.mozilla.org/show_bug.cgi?id=2055516

Copilot AI balanced review requested due to automatic review settings August 5, 2026 20:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Advances the CSP enforcement rollout by collecting violations, controlling enforcement for legacy CGI pages, and removing inline handlers.

Changes:

  • Adds a rate-limited CSP report collector with structured logging.
  • Introduces CGI enforcement controls and preserves modal bug-view enforcement.
  • Converts inline handlers to nonce-protected listeners and adds CSP tests.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
template/en/default/bug/edit.html.tmpl Makes bug editing CSP-compatible.
template/en/default/bug/create/create.html.tmpl Makes bug creation CSP-compatible.
t/csp-report.t Tests report collection and sanitization.
t/csp-enforce.t Tests CSP enforcement selection.
show_bug.cgi Explicitly enforces CSP for modal views.
Bugzilla/Constants.pm Adds reporting and CGI allowlist policy.
Bugzilla/Config/Admin.pm Configures collector rate limits.
Bugzilla/App/Plugin/Glue.pm Selects report-only or enforcing headers.
Bugzilla/App/Controller/CSPReport.pm Implements the violation collector.
Suppressed comments (1)

template/en/default/bug/edit.html.tmpl:47

  • This anchor is presented as a button, but it does not implement the Space-key behavior expected from that role, and x is not a descriptive accessible name. A native button preserves the existing click listener while providing correct keyboard semantics.
      <a href="#" id="bz_ctag_hide_error" role="button">x</a>

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread template/en/default/bug/edit.html.tmpl
Comment thread Bugzilla/App/Controller/CSPReport.pm
@dklawren
dklawren merged commit b5fd2dd into mozilla-bteam:master Aug 5, 2026
8 checks passed
@dklawren
dklawren deleted the 2055516 branch August 5, 2026 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants