Bug 2057679 - Update docker build process to pull in latest builds of vendered javascript libraries needed by the client - #2683
Open
dklawren wants to merge 3 commits into
Open
Conversation
… vendered javascript libraries needed by the client
cgsheeh
reviewed
Jul 28, 2026
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 18 out of 42 changed files in this pull request and generated no new comments.
Suppressed comments (1)
scripts/build-frontend.mjs:119
TARGET_DIRSis documented here and in the README as copying a whole asset directory, but this loop silently skips every nested directory. A library with assets below one level will therefore build successfully while shipping broken URLs. Recurse into directory entries (or use a recursive copy API) so the implementation matches that contract.
Xzzz
approved these changes
Aug 13, 2026
Xzzz
left a comment
Xzzz
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, nice cleanup and the design logic is already settled in-thread with Connor.
Few things I specifically checked:
- Dockerfile ordering:
COPY --from=assets /build/out /app/jslands before thechown -R app:app /app, and afterCOPY . /app, so permissions are correct - .gitignore entries line up exactly with TARGETS/TARGET_DIRS in build-frontend.mjs: no risk to see a generated file to be integrated into a commit
- js/duo-min.js is deleted with nothing replacing it: grepped for duo-min/DuoWeb across the repo => no template or JS references it. The Duo MFA flow is server-side OAuth redirect (Bugzilla/MFA/Duo.pm), not the old client-side SDK, so this is well dead-code removal
- The earlier Copilot comment about TARGET_DIRS not recursing into subdirectories has been correctly addressed: copyDir() in the current version does recurse now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.