Skip to content

Bug 2053504 - Need to add index to tracking_flags_values table for better performance from search #2665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dklawren wants to merge 3 commits into
base: master
Choose a base branch
from
+31 −2
Open

Bug 2053504 - Need to add index to tracking_flags_values table for better performance from search #2665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
876c42b
Bug 2053504 - Need to add index to tracking_flags_values table for be…
dklawren Jul 8, 2026
8c7270c
Copilot review fixes
dklawren Jul 9, 2026
7a06818
Drop unnecessary index and instead cache the flag values
dklawren Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 27 additions & 2 deletions extensions/TrackingFlags/lib/Flag.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,7 @@ sub preload_all_the_things {
return unless @flag_ids;

# Preload values
my $value_objects = Bugzilla::Extension::TrackingFlags::Flag::Value->match(
{tracking_flag_id => \@flag_ids});
my $value_objects = _values_for_flag_ids(\@flag_ids);

# Now populate the tracking flags with this set of value objects.
foreach my $obj (@$value_objects) {
Expand Down Expand Up @@ -319,6 +318,32 @@ sub preload_all_the_things {
@$flags = values %flag_hash;
}

# Return value objects for the given tracking flag ids.
#
# The whole tracking_flags_values table is small and changes rarely, so it is
# read once per request (Flag::Value is IS_CONFIG, so the unfiltered select is
# served from memcached as well) and sliced in perl. Querying per call meant a
# query returning roughly half the table for every Flag->match, which happens
# once per bug whenever custom fields are collected - see the
# active_custom_fields call in Bugzilla::Bug::to_hash.
sub _values_for_flag_ids {
my ($flag_ids) = @_;
my $rows = Bugzilla->request_cache->{tracking_flags_value_rows} ||= do {
my %by_flag_id;
foreach my $value (Bugzilla::Extension::TrackingFlags::Flag::Value->get_all) {
push @{$by_flag_id{$value->tracking_flag_id}}, {%$value};
}
\%by_flag_id;
};

# Callers store a back-reference to their own flag object on each value, so
# fresh objects are returned rather than the cached rows themselves.
return [
map { Bugzilla::Extension::TrackingFlags::Flag::Value->new_from_hash({%$_}) }
map { @{$rows->{$_} || []} } @$flag_ids
];
}

###############################
#### Validators ####
###############################
Expand Down
4 changes: 4 additions & 0 deletions extensions/TrackingFlags/lib/Flag/Value.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ use Scalar::Util qw(blessed weaken);

use constant DB_TABLE => 'tracking_flags_values';

# Values change rarely, so unfiltered selects are cached in memcached and the
# cache is cleared automatically when a value is created, updated or deleted.
use constant IS_CONFIG => 1;

use constant DB_COLUMNS => qw(
id
tracking_flag_id
Expand Down