Replace shared_ptr unique checks - #3793
Merged
rhaschke merged 1 commit intoJul 20, 2026
Merged
Conversation
This upstreams the focused std::shared_ptr::unique() portions of RoboStack downstream patches `patch/ros-rolling-moveit-core.patch`, `patch/ros-rolling-moveit-planners-ompl.patch`, and `patch/ros-rolling-moveit-ros-planning.patch`. std::shared_ptr::unique() is removed in C++20. Use use_count() comparisons instead while preserving the existing ownership checks. This intentionally does not touch moveit_ros/robot_interaction because that file is already covered by moveit#3792. Signed-off-by: Tobias Fischer <info@tobiasfischer.info>
Contributor
Author
|
FYI @wep21 @traversaro, opened from the RoboStack patch tracking effort in RoboStack/robostack.github.io#16. |
rhaschke
approved these changes
Jul 20, 2026
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of an effort to contribute RoboStack downstream patches back upstream.
Origin: focused portions of
patch/ros-rolling-moveit-core.patch,patch/ros-rolling-moveit-planners-ompl.patch, andpatch/ros-rolling-moveit-ros-planning.patch, authored by Daisuke Nishimatsu.std::shared_ptr::unique()was removed in C++20. This replaces the remaining source-level ownership checks with equivalentuse_count()comparisons while preserving the existing logic.This intentionally leaves
moveit_ros/robot_interactionuntouched because that file is already covered by #3792.