resolute: explicit <rclcpp/executors.hpp> include in servo_ros_fixture - #3787
Open
nbbrooks wants to merge 1 commit into
Open
resolute: explicit <rclcpp/executors.hpp> include in servo_ros_fixture#3787nbbrooks wants to merge 1 commit into
nbbrooks wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3787 +/- ##
==========================================
+ Coverage 46.23% 46.25% +0.02%
==========================================
Files 726 726
Lines 59512 59511 -1
Branches 7622 7623 +1
==========================================
+ Hits 27509 27519 +10
+ Misses 31836 31826 -10
+ Partials 167 166 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…s_fixture On ROS Rolling, rclcpp/rclcpp.hpp no longer transitively includes executors.hpp. servo_ros_fixture uses SingleThreadedExecutor directly, so add the explicit include. No-op on older distros where the transitive include still fires.
nbbrooks
force-pushed
the
nbbrooks/servo-fixture-executors-include
branch
from
July 26, 2026 05:10
773ca31 to
27a8122
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On rolling-resolute,
rclcpp/rclcpp.hppno longer transitively pulls<rclcpp/executors.hpp>. Test usesrclcpp::executors::SingleThreadedExecutorand fails to compile without the explicit include. On humble/jazzy/kilted the transitive still works, so this is additive-only — safe on all distros.Checklist