TOOLS-4238 Start moving inline shell to scripts and use env vars to pass expansions#1024
Merged
autarch merged 1 commit intoJul 16, 2026
Conversation
Collaborator
Author
autarch
force-pushed
the
07-09-tools-4238_move_some_inline_shell_to_a_script_and_use_env_vars_to_pass_expansions
branch
3 times, most recently
from
July 14, 2026 15:42
77e55ae to
e2a94da
Compare
autarch
force-pushed
the
07-09-tools-4238_move_some_inline_shell_to_a_script_and_use_env_vars_to_pass_expansions
branch
3 times, most recently
from
July 15, 2026 16:22
d6e7eec to
f8aa3f5
Compare
autarch
marked this pull request as ready for review
July 15, 2026 18:14
autarch
changed the title
autarch
changed the title
mmcclimon
approved these changes
Jul 15, 2026
mmcclimon
left a comment
mmcclimon
left a comment
Collaborator
There was a problem hiding this comment.
Oh sure, LGTM % the thing that's probably meant for a later PR.
| set -o pipefail | ||
| set -o verbose | ||
|
|
||
| ${_set_shell_env} |
Collaborator
There was a problem hiding this comment.
This seems like a mistake (in this PR).
Collaborator
Author
There was a problem hiding this comment.
But yet all tests passed?!
Collaborator
Author
There was a problem hiding this comment.
Oh, I see. This code doesn't need anything from _set_shell_env, so it just works.
autarch
force-pushed
the
07-09-tools-4238_move_some_inline_shell_to_a_script_and_use_env_vars_to_pass_expansions
branch
from
July 15, 2026 19:07
f8aa3f5 to
5052203
Compare
This was referenced Jul 15, 2026
autarch
force-pushed
the
07-09-tools-4238_move_some_inline_shell_to_a_script_and_use_env_vars_to_pass_expansions
branch
from
July 16, 2026 17:56
5052203 to
5ed58be
Compare
autarch
force-pushed
the
07-09-tools-4238_move_some_inline_shell_to_a_script_and_use_env_vars_to_pass_expansions
branch
from
July 16, 2026 17:56
5ed58be to
7f26771
Compare
Collaborator
Author
This was referenced Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first of a series of PRs to change how we execute shell code in the Evergreen config. The ultimate goal is to remove the
_set_shell-envexpansion. This wil be replaced by theenvkey for each comand. We will turn expansions into env vars this way.This first PR only updates the "run make target" function as an example.