Skip to content

chore: bump js-yaml version COMPASS-10911 - #8286

Open
dudaschar wants to merge 6 commits into
mainfrom
COMPASS-10911
Open

chore: bump js-yaml version COMPASS-10911#8286
dudaschar wants to merge 6 commits into
mainfrom
COMPASS-10911

Conversation

@dudaschar

Copy link
Copy Markdown
Collaborator

Description

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • If this change could impact the load on the MongoDB cluster, please describe the expected and worst case impact
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

Copilot AI review requested due to automatic review settings July 27, 2026 13:03
@dudaschar
dudaschar requested a review from a team as a code owner July 27, 2026 13:03
@dudaschar
dudaschar requested a review from gribnoysup July 27, 2026 13:03
@dudaschar dudaschar self-assigned this Jul 27, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the monorepo’s js-yaml dependency to a newer major version across the root and several workspaces. The main review concern is dependency compatibility: packages/bson-transpilers currently relies on js-yaml-js-types, which declares a peer dependency on js-yaml@4.x, making the bump to js-yaml@^5.2.2 likely to cause install-time peer resolution failures and/or runtime incompatibilities.

Changes:

  • Bumped js-yaml from ^4.3.0 to ^5.2.2 in the root and multiple workspace package.json files.
  • Updated package-lock.json to reflect the new js-yaml version and resolved dependency tree.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/hadron-build/package.json Bumps js-yaml dependency version.
packages/compass-preferences-model/package.json Bumps js-yaml dependency version.
packages/bson-transpilers/package.json Bumps js-yaml dependency version (conflicts with js-yaml-js-types peer requirement).
package.json Bumps root js-yaml devDependency version.
package-lock.json Updates lockfile to js-yaml@5.2.2 and related entries.

Comment thread packages/bson-transpilers/package.json
Comment thread package-lock.json
Comment on lines +37622 to +37623
"node_modules/mongodb-schema/node_modules/js-yaml": {
"version": "4.3.0",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pulling "affected" version as a transitive dep of a package we own, so you'd have to update it also (I think this package is in devtools-shared repo)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, I'll update there as well.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still have this version because the mcp repo is depending on the old mongodb-schema. I'll update there as well.

@dudaschar
dudaschar requested a review from gribnoysup July 30, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants