chore: bump js-yaml version COMPASS-10911 - #8286
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the monorepo’s js-yaml dependency to a newer major version across the root and several workspaces. The main review concern is dependency compatibility: packages/bson-transpilers currently relies on js-yaml-js-types, which declares a peer dependency on js-yaml@4.x, making the bump to js-yaml@^5.2.2 likely to cause install-time peer resolution failures and/or runtime incompatibilities.
Changes:
- Bumped
js-yamlfrom^4.3.0to^5.2.2in the root and multiple workspacepackage.jsonfiles. - Updated
package-lock.jsonto reflect the newjs-yamlversion and resolved dependency tree.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/hadron-build/package.json | Bumps js-yaml dependency version. |
| packages/compass-preferences-model/package.json | Bumps js-yaml dependency version. |
| packages/bson-transpilers/package.json | Bumps js-yaml dependency version (conflicts with js-yaml-js-types peer requirement). |
| package.json | Bumps root js-yaml devDependency version. |
| package-lock.json | Updates lockfile to js-yaml@5.2.2 and related entries. |
| "node_modules/mongodb-schema/node_modules/js-yaml": { | ||
| "version": "4.3.0", |
There was a problem hiding this comment.
This is pulling "affected" version as a transitive dep of a package we own, so you'd have to update it also (I think this package is in devtools-shared repo)
There was a problem hiding this comment.
nice, I'll update there as well.
There was a problem hiding this comment.
We still have this version because the mcp repo is depending on the old mongodb-schema. I'll update there as well.
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes