fix(manager): ограничить payload /deliveries-active whitelist'ом#427
Open
Ibochkarev wants to merge 1 commit into
Open
fix(manager): ограничить payload /deliveries-active whitelist'ом#427Ibochkarev wants to merge 1 commit into
Ibochkarev wants to merge 1 commit into
Conversation
GET /api/mgr/deliveries-active previously returned full msDelivery::toArray(), leaking integration properties/class/validation_rules to any authenticated manager. Serve only id/name/price/active/position via DeliveriesController.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
GET /api/mgr/deliveries-activeотдавал полный$item->toArray()моделиmsDelivery. В ответ попадалиproperties,class,validation_rulesи прочие внутренние поля интеграций доставки. Маршрут доступен любому аутентифицированному менеджеру (только Auth, безmssetting_save).Изменения:
DeliveriesController::getActiveDropdown().ACTIVE_DROPDOWN_FIELDS:id,name,price,active,position.ms3_*через lexicon; добавлена сортировка поposition.activeостаётся integer0|1, как в прежнемtoArray().Контракт: с
/deliveries-activeбольше не приходятproperties/class/validation_rules/description/logoи т.п. Полный CRUD по-прежнему на/api/mgr/deliveriesподmssetting_save.Тип изменений
Связанные Issues
Closes #416
Как это было протестировано?
project.test)Команды и результат:
Red-green: добавление
propertiesв whitelist валит тест; после отката — OK.Live:
getActiveDropdown()→ 9 доставок, ключи толькоid,name,price,active,position, без secrets.Конфигурация тестирования:
Чеклист
php -lДополнительные заметки
Out of scope (как в issue):
/statuses-dropdownпо-прежнему отдаётtoArray(); у статусов нетproperties/classкак у доставок — отдельная задача при необходимости.PermissionMiddlewareсохранён (dropdown для форм заказа).