fix(client): drop modal chrome from embedded settings sections - #2
Merged
Anans-Ivresse merged 1 commit intoAug 16, 2026
Merged
Conversation
The MemoryPanel and SettingsPanel both render in two modes: a portal modal (styles.panel, full chrome) and an embedded variant used by the 'settings.section' slot inside the DSH settings page. The embedded branch reused the modal panel style with only width/maxWidth/maxHeight overridden, so the section rendered as a floating card — white background, 12px radius, 16px padding, and a 0 8px 40px shadow — inside the settings host's own surface, producing an unwanted inset box with a shadow on the left edge of the settings page. The embedded variant now uses a plain full-width flex column with no background, radius, padding, or shadow; the modal (portal) mode keeps the panel chrome unchanged. Adds a regression test asserting both panels' embedded branches carry none of the modal-only chrome.
Collaborator
|
已收到你的 PR，感谢贡献！明天我会测试后合并 🙏 |
Anans-Ivresse
added a commit
that referenced
this pull request
Aug 16, 2026
Collaborator
|
Hi @Liuxin4950, thanks for the contribution! 🙏 I tested your PR:
Merged ✅ (squash) and released as v0.2.6 on npm. Great fix — the embedded panels now render flat in the settings page instead of floating cards. Looking forward to more contributions! 🚀 |
Anans-Ivresse
pushed a commit
that referenced
this pull request
Aug 16, 2026
The MemoryPanel and SettingsPanel both render in two modes: a portal modal (styles.panel, full chrome) and an embedded variant used by the 'settings.section' slot inside the DSH settings page. The embedded branch reused the modal panel style with only width/maxWidth/maxHeight overridden, so the section rendered as a floating card — white background, 12px radius, 16px padding, and a 0 8px 40px shadow — inside the settings host's own surface, producing an unwanted inset box with a shadow on the left edge of the settings page. The embedded variant now uses a plain full-width flex column with no background, radius, padding, or shadow; the modal (portal) mode keeps the panel chrome unchanged. Adds a regression test asserting both panels' embedded branches carry none of the modal-only chrome.
Anans-Ivresse
added a commit
that referenced
this pull request
Aug 16, 2026
Anans-Ivresse
pushed a commit
that referenced
this pull request
Aug 16, 2026
The MemoryPanel and SettingsPanel both render in two modes: a portal modal (styles.panel, full chrome) and an embedded variant used by the 'settings.section' slot inside the DSH settings page. The embedded branch reused the modal panel style with only width/maxWidth/maxHeight overridden, so the section rendered as a floating card — white background, 12px radius, 16px padding, and a 0 8px 40px shadow — inside the settings host's own surface, producing an unwanted inset box with a shadow on the left edge of the settings page. The embedded variant now uses a plain full-width flex column with no background, radius, padding, or shadow; the modal (portal) mode keeps the panel chrome unchanged. Adds a regression test asserting both panels' embedded branches carry none of the modal-only chrome.
Anans-Ivresse
added a commit
that referenced
this pull request
Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MemoryPanel and SettingsPanel both render in two modes: a portal modal (styles.panel, full chrome) and an embedded variant used by the 'settings.section' slot inside the DSH settings page. The embedded branch reused the modal panel style with only width/maxWidth/maxHeight overridden, so the section rendered as a floating card — white background, 12px radius, 16px padding, and a 0 8px 40px shadow — inside the settings host's own surface, producing an unwanted inset box with a shadow on the left edge of the settings page.
The embedded variant now uses a plain full-width flex column with no background, radius, padding, or shadow; the modal (portal) mode keeps the panel chrome unchanged.
Adds a regression test asserting both panels' embedded branches carry none of the modal-only chrome.