feat: extract @module-federation/data-fetch from bridge-react - #4978
Open
tonoizer wants to merge 11 commits into
Open
feat: extract @module-federation/data-fetch from bridge-react#4978tonoizer wants to merge 11 commits into
tonoizer wants to merge 11 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: 064221f The changes in this PR will be included in the next version bump. This PR includes changesets to release 49 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
… sync Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
tonoizer
marked this pull request as ready for review
August 10, 2026 21:41
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f1b1ae4f5a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Resolve pnpm-lock.yaml conflict and make @module-federation/runtime a hard dependency of @module-federation/data-fetch so the root entry's prefetch/helpers import resolves for bridge re-export consumers. Co-authored-by: Cursor <cursoragent@cursor.com>
Remove the temporary hook-safe turbo bypass from the merge commit. Co-authored-by: Cursor <cursoragent@cursor.com>
Resolve pnpm-lock.yaml conflict after latest main updates. Co-authored-by: Cursor <cursoragent@cursor.com>
Resolve pnpm-lock.yaml conflict after latest main updates. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@module-federation/data-fetch@module-federation/bridge-react/data-fetch(+ related subpaths) as backward-compatible re-exports@module-federation/bridge-vue3to re-export the same agnostic utility subset (callDataFetch,flushDataFetch,setSSREnv, cache/prefetch APIs,NoSSRRemoteInfo)@module-federation/data-fetchfor agnostic APIs, with install guidance; React-only UI APIs stay onbridge-reactAGENTS.mdthatapps/website-new/docs/must stay in sync (including locale parity) when publishable package APIs changedata-fetch,bridge-react,bridge-vue3; package added to fixed release groupMotivation
Data fetch/prefetch/cache are not React-Bridge concerns. They should be usable without Bridge and shared across React/Vue consumers without duplicating logic under
bridge-react.Vue
createLazyComponentnoteReact keeps
createLazyComponentas the component-remote UI adapter on top of the shared data-fetch core. A Vue equivalent is not required for this extraction and is not implemented here. It can land later for bridge feature completeness (component-level remotes + data loaders in Vue hosts), or as a separate PR, if that product use case is confirmed. App-level Vue remotes continue to use Vue Bridge (createBridgeComponent/createRemoteAppComponent).Testing
pnpm --filter @module-federation/data-fetch run buildpnpm --filter @module-federation/bridge-react run buildpnpm --filter @module-federation/bridge-vue3 run buildpnpm --filter @module-federation/data-fetch run test(15 tests)