fix(app): clean up online/offline listeners on Browse unmount - #7213
Open
waliser wants to merge 1 commit into
Open
fix(app): clean up online/offline listeners on Browse unmount#7213waliser wants to merge 1 commit into
waliser wants to merge 1 commit into
Conversation
Browse.vue registers window 'online'/'offline' listeners but never removes them. Since only LibraryPage is kept alive by the router, Browse unmounts every time the user navigates away (e.g. into a project) and remounts on return, leaking a new pair of closures (and pinning the whole component scope) on window each time. Over a browsing session this accumulates continuously.
Contributor
Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Browse.vueregisterswindow.addEventListener('online'/'offline', ...)but never removes the listeners.LibraryPagealive via<KeepAlive include="LibraryPage">(App.vue), soBrowse.vueunmounts every time the user navigates away (e.g. into a project) and remounts on return.window, pinning the whole component setup scope from being garbage collected. Over a browsing session this accumulates continuously, contributing to reports of high/growing memory usage while browsing mods on Linux (related: Linux-specific performance, graphical, or crashing issues [MEGA-ISSUE] #3057).Fix
Store the handlers in named refs, remove them in
onBeforeUnmount, matching the cleanup pattern already used elsewhere in the app (e.g.ContextMenu.vue,QuickInstanceSwitcher.vue).Test plan
addEventListener/removeEventListenerpairs were introduced