fix(maven): return requested file extension#6455
Merged
Merged
Conversation
Member
Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
Sychic
force-pushed
the
sychic/fix-maven-resolution
branch
from
058e1a5 to
247d89e
Compare
Sychic
force-pushed
the
sychic/fix-maven-resolution
branch
from
247d89e to
2adcdfe
Compare
aecsocket
approved these changes
Jun 21, 2026
Member
Author
|
For some context for the future, the previous manual file extension determination wasn't updated when plugin project types were introduced. This PR rewrites the logic to first filter files to the requested file extension and then performs the file name checking logic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2428, #2663