test: lock that the deck list omits cards#33
Merged
Conversation
PR #30 split the Deck response contract (light Deck for lists, DeckWithCards for detail) but no test asserted that cards is absent from list responses — the existing tests passed either way. Add a test that creates a deck WITH a card and asserts the list item has no cards key. Under the old single-schema design this would have failed (it returned the misleading cards: []), so it pins the fix. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #30 split the Deck response contract — light
Deckforlist/create/update,DeckWithCardsforget_deck— but no test asserted thatcardsis absent from list responses. The existing tests passed under both the old and new schema, so the contract wasn't pinned.What
test_list_decks_omits_cardscreates a deck with a card, then asserts the list item has nocardskey:Under the old single-schema design this would have failed —
list_decksreturned the misleadingcards: []even for decks with cards (thenoloadlie #30 removed). So the test locks the fix and would catch a regression that re-addedcardsto the light contract.test_get_one_deckalready locks the other half (detail includes cards).21 passed, 100% coverage.
🤖 Generated with Claude Code