chore: lift the fastapi<0.137 cap#133
Merged
Merged
Conversation
The cap (1.1.1) existed only because prometheus-fastapi-instrumentator <=8.0.0 crashed on FastAPI 0.137's _IncludedRouter. Fixed upstream in instrumentator 8.0.1 (issue #370). Remove fastapi<0.137 and raise the fastapi-metrics floor to >=8.0.1 so the fix is guaranteed wherever metrics are installed. Verified against FastAPI 0.138.0 + instrumentator 8.0.2: full suite green at 100%. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Lifts the temporary
fastapi<0.137cap introduced in 1.1.1, now that the upstream fix has shipped.fastapi<0.137from thefastapiextra (the base everyfastapi-*extra composes from).fastapi-metricsfloor:prometheus-fastapi-instrumentator>=6.1→>=8.0.1.Why
The cap existed solely because
prometheus-fastapi-instrumentator(≤8.0.0) readroute.pathunconditionally and crashed on FastAPI 0.137's internal_IncludedRouter. That's fixed upstream in instrumentator v8.0.1 (issue #370, closed 2026-06-22). The crash needed FastAPI ≥0.137 and instrumentator ≤8.0.0, so the FastAPI uncap is paired with an instrumentator floor that guarantees the fix wherever metrics are installed.Verification
Re-resolved and ran against the previously-forbidden combination FastAPI 0.138.0 + prometheus-fastapi-instrumentator 8.0.2:
_IncludedRoutercrash surface)just lintclean (ruff+ty)lite-bootstrap's own offline-docs
isinstance(route, Route)guard (from 1.1.1) stays in place.Release
Backward compatible with 1.2.0 — purely a resolution-constraint loosening. Release notes drafted as
planning/releases/1.2.1.md; intended as a 1.2.1 patch.🤖 Generated with Claude Code