feat: cancel() + stable error codes (#366) - #370
Draft
plrthink wants to merge 9 commits into
Draft
Conversation
Expose listContents, unzipFiles, and unzipFilesWithPassword on iOS and Android so apps can inspect archives and extract only selected entries without switching to another library. Co-authored-by: Perry <plrthink@gmail.com>
Allow aborting in-flight zip/unzip work and reject with consistent ERR_* codes on iOS and Android, including ERR_CANCELLED. Co-authored-by: Perry <plrthink@gmail.com>
This was referenced Jul 25, 2026
Co-authored-by: Perry <plrthink@gmail.com>
Co-authored-by: Perry <plrthink@gmail.com>
Remove unzipFiles/unzipFilesWithPassword and add an optional entries argument to unzip and unzipWithPassword instead, matching the existing zip overload style. Co-authored-by: Perry <plrthink@gmail.com>
4 tasks
Add Maestro coverage for listing archive entries, selective unzip via entries, and password selective unzip. Playground demos now surface assertable Listed Entries / Selective Extract / Password Selective Extract results including files that were intentionally skipped. Co-authored-by: Perry <plrthink@gmail.com>
Remove an extra closing brace left from the selective-extract cherry-pick that broke Android compilation on stacked PRs. Make the list/selective Maestro flow assert stable accessibility labels and summary markers. Co-authored-by: Perry <plrthink@gmail.com>
zip4j cannot extract ZIP_STANDARD_VARIANT_STRONG, which caused password selective extract E2E to fail with "encryption method is not supported". Map explicit STANDARD to ZIP_STANDARD like the default path. Co-authored-by: Perry <plrthink@gmail.com>
The upstream installer can exit 0 after a corrupt download, leaving maestro missing and E2E jobs failing with exit 127. Retry install and require an executable binary before continuing. Co-authored-by: Perry <plrthink@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #366 (P0):
cancel()and stable cross-platform error codes.Includes #369 (
listContents+ optionalentriesonunzip/unzipWithPassword, plus Maestro E2E for list/selective extract).APIs
cancel()— best-effort abort of in-flight zip/unzipErrorCodesmap (ERR_CANCELLED,ERR_FILE_NOT_FOUND,ERR_WRONG_PASSWORD,ERR_UNSAFE_PATH, …)Stack
Merge order: #369 → this PR → #371 → #372