🛡️ Sentinel: [HIGH] Fix path traversal in CustomEmployeeManager SetPortrait

[mleem97]

🚨 Severity: HIGH
💡 Vulnerability: The SetPortrait method in CustomEmployeeManager constructs file paths using Path.Combine(assetsDir, employeeId + ext) without validating employeeId, allowing path traversal.
🎯 Impact: A malicious mod or user input could supply an employeeId with directory traversal characters (e.g., ../../), causing arbitrary file access for reading portraits, which may lead to reading sensitive files if not properly handled or if exceptions bubble up.
🔧 Fix: Added path traversal validation employeeId.IndexOfAny(Path.GetInvalidFileNameChars()) < 0 && !employeeId.Contains("..") to SetPortrait. If validation fails, it safely falls back to a solid teal color without throwing exceptions, preventing path traversal.
✅ Verification: Compiled successfully and ran existing tests dotnet test tests/gregCore.Tests.csproj. Validated changes by reviewing the code implementation manually.

---

PR created automatically by Jules for task 11402313031241054011 started by @mleem97

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric	Results
Complexity	0
Duplication	0

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}