Fix Codex agent job subagent detection in Insight#829
Open
HagegeR wants to merge 8 commits into
Open
Conversation
Two regressions snuck back in when the /context-saving rename agent copied from the next branch (which never had the hero pattern fix). Re-applying on main: - .cm-master + .cm-wordmark: inline-flex → flex (so the hero-tag pill never shares a baseline-aligned row with the wordmark) - .hero-tag: margin-bottom → margin-top + align-self:flex-start (sits below the wordmark on its own line) - Insight wordmark italic: 1.18em → 1em, margin-left .12em → .14em - HTML order: <h1> wordmark first, <p class="hero-tag"> after (matches master/insight/context-saving) Plus making the Insight landing's "287,000+ developers" references dynamic (.js-user-count + the GitHub stats.json fetch shim), so the number matches the OSS plugin's source-of-truth count instead of drifting like the screenshots showed (290k+ on /, 287k+ here).
OG PNGs are static, so the 287,000+ number drifted away from the landing page (which already reads stats.json live). Solution: - Mark every user-count occurrence in master-og.html and context-saving-og.html with class js-user-count - render-og.mjs now fetches the same stats.json before opening the browser, then runs a one-shot DOM swap on every .js-user-count element before the screenshot Result: each render bakes the freshest count in, no manual update needed. Today's render shows 290,000+ across all three banners.
The hero green cursor was driving compositor work harder than it needed to: steps(2) + a 24px box-shadow meant the GPU repainted the full glow on every tick, which user reported as a low-FPS feel. - animation timing: 1.06s steps(2) → 1.4s ease-in-out (smooth pulse between opacity 1 and 0.28, terminal-feeling without hard flicker) - box-shadow blur: 24px → 18px and alpha .45 → .40 (lighter recompose) - add will-change:opacity + translateZ(0) so the cursor lives on its own composited layer (no repaint of surrounding text) - topnav cursor: same easing pass, renamed keyframe to nav-blink so the hero and nav don't share a single declaration name - prefers-reduced-motion now resolves to a static 0.85 opacity cursor instead of a stuck-on solid block
HagegeR
force-pushed
the
fix-codex-agent-job-subagent-insight
branch
from
778dc26 to
f1e5d5d
Compare
Contributor
|
Hi @HagegeR, review/triage를 돕고 있는 contributor입니다. 컨플릭 해결 이후 기준으로 다시 확인했습니다. 메인테이너 검증 요구사항에 맞춰 PR 설명, git history, merge 가능 여부, 타깃 테스트, 실제 extraction 동작을 함께 확인했습니다. 확인한 내용이 PR의 핵심 주장은 Codex generic agent-job worker session이 일반 관련 경로에 대해 git archaeology를 진행했습니다.
기존 검증한 내용현재 base 기준 local merge probe는 clean입니다.
추가로 아래 검증을 진행했습니다.
직접 extraction smoke check도 진행했습니다.
빌드 후 worktree도 clean 상태였고, generated artifact drift는 확인되지 않았습니다. 결론이 PR은 Insight analytics 관점에서 의미 있는 수정으로 보입니다. 이전에 확인했던 local merge conflict 우려도 현재는 해소된 상태입니다. 현재 남은 gate는 GitHub checks가 아직 보고되지 않는다는 점입니다. CI/checks가 실행되고 green이면 merge 가능하다고 판단합니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
subagent_launchedevents.report_agent_job_resulttool calls assubagent_completedevents.Why
Codex fan-out jobs can run workers as separate sessions whose first prompt starts with
You are processing one item for a generic agent job.. Those sessions were captured as ordinaryuser_promptrows, so Insight delegation metrics showed no subagents even though workers had run.Validation
pnpm exec vitest run tests/session/session-extract.test.tspassed in an installed package checkout.pnpm exec tsc --noEmitpassed in an installed package checkout.node --check insight/server.mjspassed in this branch.UserPromptSubmitrecordssubagent_launchedandPostToolUserecordssubagent_completedfor Codex agent jobs.