Make gettime a labelled argument in the new API - #67
Open
talex5 wants to merge 1 commit into
Open
Conversation
Clearer, and makes it easy to make it optional in future if we want.
avsm
reviewed
Aug 6, 2026
| let clock = ref 0.0 in | ||
| let gettime () = !clock in | ||
| Prometheus_lwt.Gauge.set_time gauge gettime | ||
| Prometheus_lwt.Gauge.set_time gauge ~gettime |
Member
There was a problem hiding this comment.
If you want this to be optional in the future then the label should go before the fixed parameter shouldn’t it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clearer, and makes it easy to make it optional in future if we want.
(deprecating the old API is the ideal time to fix this)