fix(connect): avoid watch websocket read timeouts#33
Merged
Conversation
92b048e to
7fc0415
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
Some servers were reconnecting with
java.net.SocketTimeoutException: timeout (cause: java.net.SocketException: Socket closed)while WatchService was under pressure. The server side sawcontext canceledduring auth/session setup after the client closed the WebSocket request.A normal OkHttp read timeout is a poor fit for an idle long-lived WebSocket because no session proposal may arrive for a long time. The safer pairing is no idle read timeout plus WebSocket pings; OkHttp cancels the WebSocket and notifies failure if a pong is not received for the ping interval.
Test Plan
./gradlew :core:test --tests com.minekube.connect.module.CommonModuleTest