MTA-7133-LLM-Proxy-Disconnection-Network-Isolation-Procedures #381
MTA-7133-LLM-Proxy-Disconnection-Network-Isolation-Procedures #381anarnold97 wants to merge 1 commit into
Conversation
|
Warning Review limit reached
Next review available in: 13 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR adds a new AsciiDoc procedure documenting emergency shutdown of the LLM proxy to isolate developer environments during security incidents, covering centralized (Tackle CR toggle) and standalone (firewall/network policy) modes, with verification and re-enable steps. It is wired into the master developer guide via an include directive. ChangesEmergency LLM Proxy Shutdown Documentation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/topics/developer-lightspeed/proc_emergency-llm-proxy-shutdown.adoc`:
- Around line 175-182: Correct the provider name typo in the provider list so it
reads “Azure OpenAI Service” instead of “zure OpenAI Service.” Update the
relevant entry in the developer-lightspeed emergency LLM proxy shutdown document
where the OpenAI/Azure OpenAI providers are listed, keeping the rest of the
table content unchanged.
- Around line 93-104: The verification step in
proc_emergency-llm-proxy-shutdown.adoc is misleading because `oc get pods ... |
grep proxy` will not produce the stated “No resources found...” output; update
the expected result to reflect the actual shell behavior for this command, using
the existing “Verify that no proxy pods are running” step and its “Expected
output” block as the place to adjust the wording.
- Around line 243-264: The curl validation is targeting the public
`api.openai.com` endpoint instead of the actual isolation/proxy path, so it does
not validate centralized deployments correctly. Update the `curl` example in the
emergency shutdown docs to use the proxy or workstation-specific endpoint used
by the isolation flow, and make the expected output reflect that path for both
isolated and centralized modes. Keep the guidance aligned with the surrounding
`curl` validation section so readers verify the real traffic route rather than a
single provider host.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 23625628-72fe-4a48-8b6d-a0bc320e3992
📒 Files selected for processing (2)
docs/developer-lightspeed-guide/master.adocdocs/topics/developer-lightspeed/proc_emergency-llm-proxy-shutdown.adoc
Pkylas007
left a comment
There was a problem hiding this comment.
Really minor nits and requested a clarification but thanks for the draft!
| .Procedure | ||
|
|
||
| . Open the Developer Lightspeed panel in your IDE, such as VS Code or an IntelliJ-based IDE with the MTA plugin installed. | ||
| . In the AI assistant chat input, type any plain-language query. For example, type the following query: |
There was a problem hiding this comment.
Please confirm with the engineering peeps if we have an AI assistant chat input?
IIUC, On the {ProductShortName} Analysis View page, {ProductShortName} shows an error message even before the user performs a code analysis since the LLM provider connection is blocked but please confirm with the engg folks if this is the expected behavior.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| .Procedure | ||
|
|
||
| . Open the Developer Lightspeed panel in your IDE, such as VS Code or an IntelliJ-based IDE with the MTA plugin installed. | ||
| . In the AI assistant chat input, type any plain-language query. For example, type the following query: |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…Draft) Signed-off-by: A.Arnold <anarnold@redhat.com>
9aa8485 to
f5d9890
Compare
JIRA
PREVIEW
7. LLM proxy interaction monitoring
7.1. LLM proxy request and data handling
7.2. Accessing LLM proxy pod logs
7.3. Planned audit logging capabilities
DESCRIPTION
Adds emergency LLM proxy shutdown and network isolation procedures to the Developer Lightspeed guide.
New file:
proc_emergency-llm-proxy-shutdown.adocCentralized mode (Operator / OpenShift deployments)
kai_llm_proxy_enabled: falsein the Tackle CRoc patchCLI methodsStandalone mode (manual desktop setup)
Validation
curl-based network-level checkAssembly change
docs/developer-lightspeed-guide/master.adoc— new module included aftercon_developer-lightspeed-logs.adoc