Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughNew AsciiDoc release-notes assembly and topic files for MTA 8.2.0 are added, covering new features/enhancements, deprecated features, known issues, and fixed issues. The master release-notes document and docinfo abstract are updated to include and reference the new 8.2.0 release notes. ChangesMTA 8.2.0 Release Notes Structure
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@assemblies/release-notes/assembly_mta-8-2-0.adoc`:
- Around line 17-18: The abstract currently promises sections not present;
update the role="_abstract" text in assembly_mta-8-2-0.adoc to only list the
sections actually included (new-features and fixed-issues). Edit the line that
begins with [role="_abstract"] / the following sentence so it references only
"{ProductFullName} 8.2.0 new features and fixed issues" (remove references to
Technology Preview, removed features, and known issues) to match the assembly
contents.
- Line 13: Replace the hard-coded heading "= mta 8.2.0" with the product
attribute used elsewhere so the title reads "= {ProductShortName} 8.2.0"; update
the top-level assembly heading in assembly_mta-8-2-0.adoc to use
{ProductShortName} following the same pattern as the 8.1.0 assembly to keep
branding consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 06247b99-210f-4560-8d9c-a57a1094e23b
📒 Files selected for processing (4)
assemblies/release-notes/assembly_mta-8-2-0.adocdocs/release-notes/master.adocdocs/topics/release-notes-topics/ref_fixed-issues-8-2-0.adocdocs/topics/release-notes-topics/ref_new-features-and-enhancements-8-2-0.adoc
| [role="_abstract"] | ||
| Review new features, enhancements, Technology Preview features, removed features, fixed issues, and known issues in {ProductFullName} 8.2.0. |
There was a problem hiding this comment.
Trim the abstract to the included sections.
This abstract still advertises Technology Preview, removed features, and known-issues content, but this assembly only includes the new-features and fixed-issues topics. Either add the missing includes or narrow the abstract so the page doesn't promise sections that aren't present.
♻️ Proposed fix
-[role="_abstract"]
-Review new features, enhancements, Technology Preview features, removed features, fixed issues, and known issues in {ProductFullName} 8.2.0.
+[role="_abstract"]
+Review new features, enhancements, and fixed issues in {ProductFullName} 8.2.0.Based on the existing 8.1.0 assembly pattern, the abstract should mirror the sections that are actually included.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| [role="_abstract"] | |
| Review new features, enhancements, Technology Preview features, removed features, fixed issues, and known issues in {ProductFullName} 8.2.0. | |
| [role="_abstract"] | |
| Review new features, enhancements, and fixed issues in {ProductFullName} 8.2.0. |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@assemblies/release-notes/assembly_mta-8-2-0.adoc` around lines 17 - 18, The
abstract currently promises sections not present; update the role="_abstract"
text in assembly_mta-8-2-0.adoc to only list the sections actually included
(new-features and fixed-issues). Edit the line that begins with
[role="_abstract"] / the following sentence so it references only
"{ProductFullName} 8.2.0 new features and fixed issues" (remove references to
Technology Preview, removed features, and known issues) to match the assembly
contents.
There was a problem hiding this comment.
AI: @mpershina, adjust when the RNs list is confirmed
There was a problem hiding this comment.
@mpershina, sounds good — I'll leave this as-is for now. Feel free to update the abstract once the final release notes list for 8.2.0 is confirmed.
🧠 Learnings used
Learnt from: Pkylas007
Repo: migtools/mta-documentation PR: 329
File: docs/topics/rules-development/yaml-provider-conditions.adoc:457-457
Timestamp: 2026-03-18T08:59:21.462Z
Learning: In migtools/mta-documentation, do not flag or review cross-reference (xref) anchor ID mismatches or broken xrefs in AsciiDoc (.adoc) files. Maintainers have explicitly requested ignoring xref issues for this repository. Apply this guidance to all .adoc files in the project (pattern: **/*.adoc); do not raise xref-related review comments for these files unless the directive is explicitly lifted.
Learnt from: Pkylas007
Repo: migtools/mta-documentation PR: 326
File: assemblies/ui-guide/assembly_centralized-configurations-analysis.adoc:20-20
Timestamp: 2026-03-30T15:14:19.266Z
Learning: In this repository’s AsciiDoc (.adoc) files, follow Red Hat documentation style for the specific construct: it’s acceptable to use a sentence fragment that starts with “For example, …” as a standalone sentence when it follows a preceding complete statement. Do not flag this as an AsciiDoc grammar or readability issue.
Learnt from: mpershina
Repo: migtools/mta-documentation PR: 339
File: docs/topics/vscode/proc_vscode-analyzing-application.adoc:6-6
Timestamp: 2026-04-09T08:49:54.549Z
Learning: In the documentation, when introducing an acronym/abbreviation, write the full expanded name first and then the abbreviation in parentheses. Example: "Remote Procedure Call (RPC)". Do not use the reverse order (e.g., "RPC (Remote Procedure Call)") when first defining the acronym.
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/topics/release-notes-topics/ref_fixed-issues-8-2-0.adoc`:
- Around line 29-35: The release notes section contains orphaned Jira links
without any accompanying release-note text. In the release-notes topic that
includes MTA-6211 and MTA-5199, either restore the missing prose under those
issue IDs or remove the standalone links so the section only contains complete
entries.
In `@docs/topics/release-notes-topics/ref_known-issues-8-2-0.adoc`:
- Line 54: The release notes still contain a placeholder link target, so replace
the `TBD` reference with the final Jira link or remove the link until it is
known. Update the `link:TBD` entry in the release notes topic so it resolves
correctly before merge.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 0cb2fe17-f5c7-4de8-99de-0bf3c9b3e61a
📒 Files selected for processing (6)
assemblies/release-notes/assembly_mta-8-2-0.adocdocs/release-notes/master-docinfo.xmldocs/topics/release-notes-topics/ref_fixed-issues-8-2-0.adocdocs/topics/release-notes-topics/ref_known-issues-8-2-0.adocdocs/topics/release-notes-topics/ref_new-features-and-enhancements-8-2-0.adocdocs/topics/release-notes-topics/ref_removed-features-8-2-0.adoc
✅ Files skipped from review due to trivial changes (2)
- docs/topics/release-notes-topics/ref_removed-features-8-2-0.adoc
- assemblies/release-notes/assembly_mta-8-2-0.adoc
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@docs/topics/release-notes-topics/ref_new-features-and-enhancements-8-2-0.adoc`:
- Around line 42-46: The user-facing release note heading uses the wrong casing
for .NET; update the title in the affected AsciiDoc entry so it reads “.NET
Compiler Platform” instead of “.Net Compiler Platform.” Locate the heading text
near the release note for {ProductShortName} and adjust only the wording in that
title, keeping the rest of the content unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: e706104f-30f2-48ca-ade2-22e9e9657e6b
📒 Files selected for processing (6)
assemblies/release-notes/assembly_mta-8-2-0.adocdocs/release-notes/master.adocdocs/topics/release-notes-topics/ref_deprecated-features-8-2-0.adocdocs/topics/release-notes-topics/ref_fixed-issues-8-2-0.adocdocs/topics/release-notes-topics/ref_known-issues-8-2-0.adocdocs/topics/release-notes-topics/ref_new-features-and-enhancements-8-2-0.adoc
✅ Files skipped from review due to trivial changes (5)
- docs/topics/release-notes-topics/ref_deprecated-features-8-2-0.adoc
- docs/release-notes/master.adoc
- docs/topics/release-notes-topics/ref_fixed-issues-8-2-0.adoc
- docs/topics/release-notes-topics/ref_known-issues-8-2-0.adoc
- assemblies/release-notes/assembly_mta-8-2-0.adoc
| [role="_abstract"] | ||
| This section provides a list of all features deprecated in {ProductFullName} 8.2.0. | ||
|
|
||
| The following {ProductShortName} command-line interface (CLI) commands are deprecated: |
There was a problem hiding this comment.
@eemcmullan
@ibragins Please could you review the deprecated commands? Thank you!
|
|
||
|
|
||
|
|
||
| Keycloak administrators logging in to {ProductShortName} cannot create a user:: |
| // MTA-6887 (validation) | ||
|
|
||
|
|
||
| {ProductShortName} offers an OIDC-compliant Hub provider for authentication and authorization:: |
|
|
||
| link:https://redhat.atlassian.net/browse/MTA-6893[MTA-6893] | ||
|
|
||
| {ProductShortName} supports new commands and reorganized subcommands:: |
There was a problem hiding this comment.
@eemcmullan
@ibragins Could you take a look at the enhancement description for CLI commands, please?
| + | ||
| The `mta-ops` command-line interface (CLI) is a new standalone tool that migrates stateless Red Hat OpenShift workloads. It uses a multi-stage pipeline to locally export, transform, and render your application manifests. As a result, you can safely generate and validate manifests before using standard deployment tools. | ||
| + | ||
| For more information, see link:[TBD][Migrating stateless workloads by using the mta-ops CLI]. |
There was a problem hiding this comment.
AI: Add the link to the mta-ops doc when ready
|
|
||
| link:https://redhat.atlassian.net/browse/MTA-7236[MTA-7236] | ||
|
|
||
| {ProductShortName} analysis does not match rule patterns when import statements have a wildcard:: |
There was a problem hiding this comment.
@jmle Please could you review this known issue?
|
|
||
| link:https://redhat.atlassian.net/browse/MTA-6530[MTA-6530] | ||
|
|
||
| {ProductShortName} web console completes tech discovery and analysis with errors:: |
There was a problem hiding this comment.
@jmle Could you review this known issue, please?
|
|
||
| link:https://redhat.atlassian.net/browse/MTA-6140[MTA-6140] | ||
|
|
||
| Custom rule does not trigger a violation in compiled binary application analysis:: |
There was a problem hiding this comment.
@jmle Can you please review this known issue? Thanks!
| + | ||
| link:TBD[Engineering ticket required] | ||
|
|
||
| {ProductShortName} supports C# provider compiled with .Net Compiler Platform:: |
There was a problem hiding this comment.
@mguetta1 Could you review this C# provider enhancement please?
Also, please share the engineering ticket for this enhancement.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| + | ||
| The `mta-ops` command-line interface (CLI) is a new standalone tool that migrates stateless Red Hat OpenShift workloads. It uses a multi-stage pipeline to locally export, transform, and render your application manifests. As a result, you can safely generate and validate manifests before using standard deployment tools. | ||
| + | ||
| For more information, see link:[TBD][Migrating stateless workloads by using the mta-ops CLI]. |
There was a problem hiding this comment.
🚫 [vale] reported by reviewdog 🐶
[RedHat.TermsErrors] Use 'operations' rather than 'ops'.
docs/release-notes/master.adoc new file: assemblies/release-notes/assembly_mta-8-2-0.adoc modified: docs/release-notes/master.adoc new file: docs/topics/release-notes-topics/ref_fixed-issues-8-2-0.adoc new file: docs/topics/release-notes-topics/ref_new-features-and-enhancements-8-2-0.adoc
Signed-off-by: Prabha Kylasamiyer Sundara Rajan <pkylasam@redhat.com>
|
As a fresh reader of this doc I am missing doc orientation. It is not clear to which MTA component the known issue belongs to. So maybe instead of a list of know issues we can add in the issue title the relevant component, or we can group the known issues into MTA components. |
| = Fixed issues | ||
|
|
||
| [role="_abstract"] | ||
| Review issues that have been fixed in {ProductFirstRef} version 8.2.0. |
There was a problem hiding this comment.
@dymurray Could you review the fixed issues in 8.2, please?
| link:https://redhat.atlassian.net/browse/MTA-7235[MTA-7235] | ||
|
|
||
|
|
||
| {ProductShortName} does not automatically redirect to the external identity provider for authentication:: |
| For more information, see link:[TBD][Migrating stateless workloads by using the mta-ops CLI]. | ||
|
|
||
|
|
||
| An OIDC-compliant Hub provider for authentication and authorization:: |
| + | ||
| link:TBD[Engineering ticket required] | ||
|
|
||
| C# provider compiled with `.Net` Compiler Platform:: |
There was a problem hiding this comment.
@mguetta1 Can you please review the C# provider new feature?
Hi @istein1 , I understand your concern. However, the current style guide does not mention if grouping by MTA components is a valid template. I'll bring it up with the doc team to know their thoughts on this suggestion. Thanks! @istein1 I have grouped the known issues based on MTA components. Thanks! |
Signed-off-by: Prabha Kylasamiyer Sundara Rajan <pkylasam@redhat.com>
|
|
||
| C# provider uses the `.NET` Compiler Platform SDK (Roslyn APIs) for analyses:: | ||
|
|
||
| The `C#` provider uses the `.NET` Compiler Platform software development kit (SDK) with Roslyn application programming interfaces (APIs) to analyze `.NET` and `C#` applications. As a result, you do not need custom rules and external dependencies to analyze `C#` and `.NET` projects. The provider also improves semantic analysis of applications by covering more framework references, object creation, type annotations, and attributes when parsing the source code. |
There was a problem hiding this comment.
| The `C#` provider uses the `.NET` Compiler Platform software development kit (SDK) with Roslyn application programming interfaces (APIs) to analyze `.NET` and `C#` applications. As a result, you do not need custom rules and external dependencies to analyze `C#` and `.NET` projects. The provider also improves semantic analysis of applications by covering more framework references, object creation, type annotations, and attributes when parsing the source code. | |
| The C# provider uses the .NET Compiler Platform software development kit (SDK) with Roslyn application programming interfaces (APIs) to analyze C# applications. As a result, you do not need external dependencies to analyze C# projects. The provider also improves semantic analysis of applications by covering more framework references, object creation, type annotations, and attributes when parsing the source code. |
There was a problem hiding this comment.
I don't think we support any other .NET language analysis besides C#
@dymurray @JonahSussman could you please confirm that?
There was a problem hiding this comment.
@mguetta1 Please could you confirm why we should remove custom rules in this description? While the user is free to write one, my understanding is that, they do not need to write a custom rule to run an analysis.
There was a problem hiding this comment.
That's right. The user does not need to write a custom rule to run an analysis, but it has nothing to do with the new roslyn-based implementation.
In fact, the default C# target was already available in 8.1.0, so it cannot be mentioned as an enhancement in 8.2
There was a problem hiding this comment.
@mguetta1 Can you please approve if the updates look ok to you?
Signed-off-by: Prabha Kylasamiyer Sundara Rajan <pkylasam@redhat.com>
Signed-off-by: Prabha Kylasamiyer Sundara Rajan <pkylasam@redhat.com>
| + | ||
| link:TBD[Engineering ticket required] | ||
|
|
||
| `C#` provider uses the `.NET` Compiler Platform SDK (Roslyn APIs) for analyses:: |
There was a problem hiding this comment.
@dymurray @JonahSussman Please could you review the C# provider enhancement?
vashirova
left a comment
vashirova
left a comment
There was a problem hiding this comment.
@mpershina peer review of 3 tagged RNs completed. I left 2 tiny suggestions for the Enh but nothing major. Great work overall, thank you for the opportunity.
…ents-8-2-0.adoc Co-authored-by: Valentina Ashirova <107574498+vashirova@users.noreply.github.com>
Signed-off-by: Prabha Kylasamiyer Sundara Rajan <pkylasam@redhat.com>
Signed-off-by: Prabha Kylasamiyer Sundara Rajan <pkylasam@redhat.com>
Signed-off-by: Prabha Kylasamiyer Sundara Rajan <pkylasam@redhat.com>
mguetta1
left a comment
mguetta1
left a comment
There was a problem hiding this comment.
The C# provider enhancement LGTM. Thanks!
7 participants
JIRA
Version
Previews
Summary by CodeRabbit
New Features
Bug Fixes
Deprecations
Documentation