Skip to content

Update golang.org/x/net to 0.55.0.#1460

Merged
rayfordj merged 1 commit into
migtools:masterfrom
awels:update_x_net_055
Jul 2, 2026
Merged

Update golang.org/x/net to 0.55.0.#1460
rayfordj merged 1 commit into
migtools:masterfrom
awels:update_x_net_055

Conversation

@awels

@awels awels commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Updated x/net to 0.55.0
Fixed linting errors.
updated parameters to controller-gen to match the
new version.

Summary by CodeRabbit

  • New Features

    • Improved compatibility for migration resources, including better handling of newer reference fields and additional stateful workload settings.
    • Added support for preserving cron job time zone information during conversion.
  • Bug Fixes

    • Fixed validation of NFS server reachability for more reliable address handling.
    • Updated generated configuration and documentation text for cleaner, more consistent resource descriptions.

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@awels, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 4 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ff77539d-c767-45bb-9f9c-14a81b0764a9

📥 Commits

Reviewing files that changed from the base of the PR and between c383a5d and d881bcb.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (16)
  • .github/workflows/pr-make.yml
  • Makefile
  • config/crds/migration.openshift.io_directimagemigrations.yaml
  • config/crds/migration.openshift.io_directimagestreammigrations.yaml
  • config/crds/migration.openshift.io_directvolumemigrationprogresses.yaml
  • config/crds/migration.openshift.io_directvolumemigrations.yaml
  • config/crds/migration.openshift.io_miganalytics.yaml
  • config/crds/migration.openshift.io_migclusters.yaml
  • config/crds/migration.openshift.io_mighooks.yaml
  • config/crds/migration.openshift.io_migmigrations.yaml
  • config/crds/migration.openshift.io_migplans.yaml
  • config/crds/migration.openshift.io_migstorages.yaml
  • go.mod
  • pkg/compat/conversion/appsv1/zz_conversion_generated.go
  • pkg/compat/conversion/batchv1beta/zz_conversion_generated.go
  • pkg/controller/migplan/validation.go
📝 Walkthrough

Walkthrough

This PR upgrades the Go toolchain and golang.org/x dependencies, updates the Makefile's conversion-gen invocation and tool version, regenerates CRD manifests with shortened ObjectReference descriptions and removed TODO comments, adds generated Kubernetes conversion functions for StatefulSet and CronJob fields, and fixes NFS address formatting in migplan validation.

Changes

Toolchain, CRD Regeneration, and Conversion Updates

Layer / File(s) Summary
Go toolchain and codegen version bumps
go.mod, Makefile
Go version raised to 1.25.0, toolchain directive removed, golang.org/x/net and other indirect x/* dependencies upgraded; Makefile's conversion-gen target switched to --output-file invocation and conversion-gen tool bumped to v0.35.6.
Regenerated CRD manifests
config/crds/migration.openshift.io_*.yaml
controller-gen version annotation bumped to v0.16.5 across all CRDs; verbose ObjectReference description blocks shortened and TODO placeholder lines removed throughout spec/status schemas.
Generated conversion function updates
pkg/compat/conversion/appsv1/zz_conversion_generated.go, pkg/compat/conversion/batchv1beta/zz_conversion_generated.go
Adds registration and Convert_* functions for StatefulSetOrdinals and StatefulSetPersistentVolumeClaimRetentionPolicy, propagates MaxUnavailable and related StatefulSetSpec fields, and copies TimeZone in CronJobSpec conversions.
NFS address construction fix
pkg/controller/migplan/validation.go
NFS TCP dial address built via net.JoinHostPort instead of fmt.Sprintf.

Estimated code review effort: 2 (Simple) | ~15 minutes

Sequence Diagram(s)

Not applicable — the changes are dependency/version bumps, generated code, and CRD schema text updates without new multi-component control flow.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is specific and accurately reflects one real part of the changeset: the golang.org/x/net upgrade.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@awels
awels force-pushed the update_x_net_055 branch from c383a5d to 9eb68d8 Compare July 1, 2026 20:00
Updated x/net to 0.55.0
Fixed linting errors.
updated controller-gen to v0.20.0
updated parameters to controller-gen to match the
new version.
update conversion-gen to v0.35.6

Signed-off-by: Alexander Wels <awels@redhat.com>
@awels
awels force-pushed the update_x_net_055 branch from 9eb68d8 to d881bcb Compare July 1, 2026 20:35
@istein1
istein1 requested review from dymurray, jmontleon and midays July 2, 2026 07:22

@rayfordj rayfordj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@rayfordj
rayfordj merged commit 3ee5ec8 into migtools:master Jul 2, 2026
2 checks passed
istein1 pushed a commit that referenced this pull request Jul 5, 2026
Updated x/net to 0.55.0
Fixed linting errors.
updated controller-gen to v0.20.0
updated parameters to controller-gen to match the
new version.
update conversion-gen to v0.35.6

Signed-off-by: Alexander Wels <awels@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants