Cross-group (N)RPN handling in umpToBytestream (Ref #30) - #35
Open
sauloverissimo wants to merge 1 commit into
Open
Cross-group (N)RPN handling in umpToBytestream (Ref #30)#35sauloverissimo wants to merge 1 commit into
sauloverissimo wants to merge 1 commit into
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi folks,
Split out from #34 as requested. This is the cross-group (N)RPN fix for #30.
The cache in umpToBytestream is keyed by channel only, so the same channel across different groups on one instance suppresses the parameter number on the later group. This resets the cache when the group changes (one byte, lastGroupSeen). Single-group and setFilterGroup output stays byte-identical, so current users aren't affected.
No rush on this one. If you have a different direction in mind for the long term, I can rework it.