Fix embedded schema to distinguish between flags and enums#297
Open
naegelejd wants to merge 2 commits into
Open
Fix embedded schema to distinguish between flags and enums#297naegelejd wants to merge 2 commits into
naegelejd wants to merge 2 commits into
Conversation
This was referenced Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the bug described in #296 .
Open Question
How do we want to support compatibilty with files generated by previous versions of Yardl?
With this patch, any pre-existing stream on disk will now fail the string-equality schema check inside
BinaryProtocolReader.__init__and its C++/Matlab counterparts, because:{"name":"DaysOfWeek","values":[...]}form.expected_schemais re-emitted with this fix in the new wrapped form.==on the raw JSON string — no normalization, no structural compare.Options
Thoughts
I'm already working on a general-purpose dynamic Yardl reader feature, which requires dynamically parsing the embedded JSON schema string. Perhaps we should consider a two-step schema validation mechanism:
Example:
and the Reader's schema check changes to: