agentHost: keep peer database alive during multi-root diffs - #331759
Merged
Dmitriy Vasyura (dmitrivMS) merged 1 commit intoAug 20, 2026
Merged
Conversation
Await multi-root turn diff computation before releasing the tracked-edit database reference. Add a regression test that verifies asynchronous peer database reads finish before disposal.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes premature peer session database disposal during asynchronous multi-root turn diff computation.
Changes:
- Awaits multi-root diff computation before cleanup.
- Adds regression coverage verifying reads complete before disposal.
Show a summary per file
| File | Description |
|---|---|
src/vs/platform/agentHost/node/agentHostChangesetService.ts |
Keeps the tracked database reference alive through multi-root diffing. |
src/vs/platform/agentHost/test/node/agentHostChangesetService.test.ts |
Tests peer database read/disposal ordering. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
Dmitriy Vasyura (dmitrivMS)
marked this pull request as ready for review
August 20, 2026 17:05
Dmitriy Vasyura (dmitrivMS)
approved these changes
Aug 20, 2026
Dmitriy Vasyura (dmitrivMS)
deleted the
chrmarti/agents/log-analysis-fix-candidate-issues-f4ada6e1
branch
August 20, 2026 17:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
When a turn belongs to a peer chat, the changeset service opens that chat's session database for tracked-edit fallback. The multi-root path returned its promise from inside a
trywithout awaiting it, so thefinallyblock disposed the database reference while repository diffing was still running. This produced repeatedSessionDatabase has been disposederrors and could omit fallback changes from turn changesets.Testing
npm run transpile-client./scripts/test.sh --run src/vs/platform/agentHost/test/node/agentHostChangesetService.test.tsawait, with disposal occurring before the delayed database read