Skip to content

agentHost: Address session catalog review feedback - #331758

Merged
Sandeep Somavarapu (sandy081) merged 1 commit into
mainfrom
agents/331679-review-followup
Aug 20, 2026
Merged

agentHost: Address session catalog review feedback#331758
Sandeep Somavarapu (sandy081) merged 1 commit into
mainfrom
agents/331679-review-followup

Conversation

@sandy081

Copy link
Copy Markdown
Member

Follow-up to #331679.

Addresses the post-merge review feedback:

  • Reapply current workspace filtering to the retained session-list projection before a failed backend refresh can leave stale entries visible.
  • Replace the ineffective epoch-race test with a registry snapshot race that proves an already-started listing restarts after mutation.
  • Document scheduled backoff versus trigger-driven retries accurately.

The retained projection intentionally only narrows while offline; newly eligible sessions arrive through the next successful listing or session-added notification.

Validation

  • npm run typecheck-client
  • npm run compile
  • npm run hygiene
  • 660 affected tests passed
  • git diff --check

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings August 20, 2026 07:56
@sandy081 Sandeep Somavarapu (sandy081) added this to the 1.135.0 milestone Aug 20, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Hardens Agent Host session catalog behavior during workspace changes and concurrent registry mutations.

Changes:

  • Re-filters retained sessions before failed refreshes can expose stale entries.
  • Replaces the epoch race test with a registry snapshot race test.
  • Clarifies retry and backoff documentation.
Show a summary per file
File Description
agentHostSessionListStore.ts Narrows cached sessions on workspace changes.
agentHostChatContribution.test.ts Tests filtering when refresh fails.
agentService.test.ts Verifies listing restarts after registry mutation.
AGENTS.md Documents client-specific retry behavior.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 4/4 changed files
  • Comments generated: 0
  • Review effort level: Balanced

@sandy081
Sandeep Somavarapu (sandy081) merged commit 8c79b49 into main Aug 20, 2026
28 checks passed
@sandy081
Sandeep Somavarapu (sandy081) deleted the agents/331679-review-followup branch August 20, 2026 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants