agentHost: Address session catalog review feedback - #331758
Merged
Sandeep Somavarapu (sandy081) merged 1 commit intoAug 20, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sandeep Somavarapu (sandy081)
enabled auto-merge (squash)
August 20, 2026 07:57
Copilot started reviewing on behalf of
Sandeep Somavarapu (sandy081)
August 20, 2026 07:57
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Hardens Agent Host session catalog behavior during workspace changes and concurrent registry mutations.
Changes:
- Re-filters retained sessions before failed refreshes can expose stale entries.
- Replaces the epoch race test with a registry snapshot race test.
- Clarifies retry and backoff documentation.
Show a summary per file
| File | Description |
|---|---|
agentHostSessionListStore.ts |
Narrows cached sessions on workspace changes. |
agentHostChatContribution.test.ts |
Tests filtering when refresh fails. |
agentService.test.ts |
Verifies listing restarts after registry mutation. |
AGENTS.md |
Documents client-specific retry behavior. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Balanced
Martin Aeschlimann (aeschli)
approved these changes
Aug 20, 2026
Sandeep Somavarapu (sandy081)
deleted the
agents/331679-review-followup
branch
August 20, 2026 09:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #331679.
Addresses the post-merge review feedback:
The retained projection intentionally only narrows while offline; newly eligible sessions arrive through the next successful listing or session-added notification.
Validation
npm run typecheck-clientnpm run compilenpm run hygienegit diff --check