Skip to content

feax: Add revealUriInOS command and migrate existing revealFileInOS consumers - #331755

Open
n-gist (n-gist) wants to merge 2 commits into
microsoft:mainfrom
n-gist:fix-revealFileInOS-consumers
Open

feax: Add revealUriInOS command and migrate existing revealFileInOS consumers#331755
n-gist (n-gist) wants to merge 2 commits into
microsoft:mainfrom
n-gist:fix-revealFileInOS-consumers

Conversation

@n-gist

@n-gist n-gist (n-gist) commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Fixes #331687

Adds revealUriInOS command that operates on the provided URI argument independently of Explorer View selection.

Migrates existing revealFileInOS consumers to revealUriInOS.

Aspects may be worth considering:

  • Command name
  • Command placement (currently placed alongside revealFileInOS for familiarity)
  • Whether to support URI[] arguments

Copilot AI balanced review requested due to automatic review settings August 20, 2026 06:15
@vs-code-engineering

Copy link
Copy Markdown
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

Ladislau Szomoru (@lszomoru)

Matched files:

  • extensions/git/src/commands.ts

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a URI-specific OS reveal command, avoiding Explorer selection interference, and migrates existing consumers.

Changes:

  • Registers revealUriInOS for direct URI handling.
  • Migrates Git, TypeScript, Copilot, and chat customization consumers.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/vs/workbench/contrib/files/electron-browser/fileActions.contribution.ts Registers the new command.
src/vs/workbench/contrib/chat/browser/aiCustomization/aiCustomizationManagement.contribution.ts Migrates customization reveal action.
src/vs/workbench/contrib/chat/browser/agentPluginActions.ts Migrates plugin folder action.
src/vs/workbench/contrib/chat/browser/actions/createPluginAction.ts Migrates created-plugin reveal.
src/vs/workbench/contrib/chat/browser/actions/chatPluginActions.ts Migrates marketplace folder reveal.
extensions/typescript-language-features/src/typescriptServiceClient.ts Migrates TS server log reveal.
extensions/git/src/commands.ts Migrates Git resource reveal.
extensions/copilot/src/extension/log/vscode-node/requestLogTree.ts Migrates exported log reveals.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

revealFileInOS may ignore the passed URI or pick additional URIs from Explorer selection depending on UI state

3 participants