agentHost: cover client-hosted filesystem E2E - #331740
Open
roblourens wants to merge 2 commits into
Open
Conversation
Add conformance coverage for reverse AHP filesystem operations and preserve protocol error codes in the test client. Document the binary write corruption exposed by the new coverage. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds conformance coverage for client-hosted filesystem operations over AHP.
Changes:
- Adds 24 reverse filesystem E2E scenarios.
- Preserves filesystem error codes in the test client.
- Documents binary-write corruption and refreshes coverage snapshots.
Show a summary per file
| File | Description |
|---|---|
serverIntegrationTestHelpers.ts |
Maps reverse filesystem errors to AHP codes. |
clientHostedFilesystemSuite.ts |
Adds client-hosted filesystem conformance tests. |
agentHostE2ESuites.ts |
Registers the new suite. |
KNOWN_ISSUES.md |
Documents binary-write corruption. |
coverage/summary.json |
Updates implementation coverage. |
coverage/protocol-surface.json |
Updates protocol coverage. |
Review details
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 4/6 changed files
- Comments generated: 3
- Review effort level: Balanced
Use an exclusive reverse write, cover the concurrent create-only contract, explain the known-issue gate, and document the split filesystem suites. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
roblourens
marked this pull request as ready for review
August 20, 2026 02:36
roblourens
enabled auto-merge (squash)
August 20, 2026 02:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Coverage
The targeted
agentHostFileSystemProvider.tscoverage moves from:The aggregate native V8 totals have small run-to-run variance because asynchronously loaded provider paths fluctuate. The final full run reports 75.02% lines, 70.75% functions, and 67.01% branches.
Validation
npm run typecheck-clientnode build/next/index.ts transpilenpm run test-agent-host-e2e-coverage(582 passing, 120 expected pending)npm run valid-layers-checkgit diff --checkKnown limitation
The opt-in
client-hosted resourceWrite decodes base64 contentscenario demonstrates that reverse binary writes currently pass bytes through UTF-8 and corrupt non-UTF-8 data. This PR keeps the failing contract behindAGENT_HOST_RUN_KNOWN_ISSUES=1and records it inKNOWN_ISSUES.md; it does not change product behavior.(Written by Copilot)