Skip to content

Pause automatic updates on metered connections - #331701

Merged
Dmitriy Vasyura (dmitrivMS) merged 8 commits into
mainfrom
dev/dmitriv/metered-update-checks
Aug 20, 2026
Merged

Pause automatic updates on metered connections#331701
Dmitriy Vasyura (dmitrivMS) merged 8 commits into
mainfrom
dev/dmitriv/metered-update-checks

Conversation

@dmitrivMS

@dmitrivMS Dmitriy Vasyura (dmitrivMS) commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator
  • skip automatic update checks, latest-version probes, overwrite checks, and downloads while the connection is metered
  • await the renderer's initial metered sample before update initialization can schedule automatic work
  • defer unmetered resumption until platform post-initialization finishes, preserving pending-update recovery and startup cleanup
  • keep deferred automatic intent coupled to the private main-process update state without changing the public update IPC state
  • resume preserved deferred work when automatic update mode is re-enabled while already unmetered
  • recheck metering after awaited overwrite probes and immediately before the Win32 installer download request
  • preserve explicit user-triggered update actions and already-started requests
  • skip automatic post-update information fetching while metered while preserving the explicit command
  • keep metered messaging centralized and scoped to background activities known to honor the setting

Fixes #297350

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings August 19, 2026 20:00
@dmitrivMS Dmitriy Vasyura (dmitrivMS) added install-update VS Code installation and upgrade system issues network Network related issues labels Aug 19, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pauses background update activity on metered connections while preserving explicit user actions.

Changes:

  • Guards automatic checks, downloads, probes, and post-update requests.
  • Resumes automatic update processing when unmetered.
  • Centralizes metered-connection messaging in the status bar.
Show a summary per file
File Description
abstractUpdateService.ts Adds metered guards and resume handling.
abstractUpdateService.test.ts Tests metered update behavior.
postUpdateWidget.ts Skips automatic post-update requests.
postUpdateWidget.test.ts Tests automatic and explicit requests.
updateTooltip.ts Removes metered-specific tooltip messaging.
updateTitleBarEntry.test.ts Updates tooltip test setup.
meteredConnectionStatus.ts Expands centralized status messaging.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 7/7 changed files
  • Comments generated: 3
  • Review effort level: Balanced

Comment thread src/vs/platform/update/electron-main/abstractUpdateService.ts Outdated
Comment thread src/vs/platform/update/electron-main/abstractUpdateService.ts
Comment thread src/vs/workbench/contrib/update/test/browser/postUpdateWidget.test.ts Outdated
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 7/7 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment thread src/vs/platform/update/electron-main/abstractUpdateService.ts
Comment thread src/vs/platform/update/electron-main/abstractUpdateService.ts
Comment thread src/vs/platform/update/electron-main/abstractUpdateService.ts Outdated
Comment thread src/vs/workbench/contrib/meteredConnection/browser/meteredConnectionStatus.ts Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 10/10 changed files
  • Comments generated: 2
  • Review effort level: Balanced

Comment thread src/vs/platform/update/electron-main/abstractUpdateService.ts
Comment thread src/vs/platform/update/electron-main/abstractUpdateService.ts
Comment thread src/vs/platform/update/electron-main/abstractUpdateService.ts
Comment thread src/vs/platform/update/electron-main/updateService.win32.ts Outdated
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 13/13 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@dmitrivMS
Dmitriy Vasyura (dmitrivMS) marked this pull request as ready for review August 20, 2026 22:09
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dmitrivMS
Dmitriy Vasyura (dmitrivMS) merged commit c4f99fb into main Aug 20, 2026
44 of 45 checks passed
@dmitrivMS
Dmitriy Vasyura (dmitrivMS) deleted the dev/dmitriv/metered-update-checks branch August 20, 2026 23:58
@vs-code-engineering vs-code-engineering Bot added this to the 1.135.0 milestone Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

install-update VS Code installation and upgrade system issues network Network related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Metered connection UI interactions for VS Code Update

3 participants