Pause automatic inline completions on metered connections - #331691
Open
Dmitriy Vasyura (dmitrivMS) wants to merge 6 commits into
Open
Pause automatic inline completions on metered connections#331691Dmitriy Vasyura (dmitrivMS) wants to merge 6 commits into
Dmitriy Vasyura (dmitrivMS) wants to merge 6 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Dmitriy Vasyura (dmitrivMS)
August 19, 2026 19:03
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Pauses automatic network-backed inline completions on metered connections while preserving explicit and in-flight requests.
Changes:
- Adds provider network-usage metadata and RPC propagation.
- Gates automatic network-backed provider calls.
- Adds coverage for metered-connection behavior.
Show a summary per file
| File | Description |
|---|---|
src/vscode-dts/vscode.proposed.inlineCompletionsAdditions.d.ts |
Adds network-usage metadata. |
src/vs/workbench/api/common/extHostLanguageFeatures.ts |
Sends metadata through RPC. |
src/vs/workbench/api/common/extHost.protocol.ts |
Extends the RPC contract. |
src/vs/workbench/api/browser/mainThreadLanguageFeatures.ts |
Applies the metered-connection gate. |
src/vs/workbench/api/test/browser/extHostLanguageFeatures.test.ts |
Tests gating and preserved requests. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 4/5 changed files
- Comments generated: 1
- Review effort level: Balanced
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Dmitriy Vasyura (dmitrivMS)
August 19, 2026 22:41
View session
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Dmitriy Vasyura (dmitrivMS)
August 19, 2026 23:57
View session
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dmitriy Vasyura (dmitrivMS)
marked this pull request as ready for review
August 20, 2026 21:30
Dmitriy Vasyura (dmitrivMS)
requested a review
from Henning Dieterichs (hediet)
August 20, 2026 21:30
Copilot started reviewing on behalf of
Dmitriy Vasyura (dmitrivMS)
August 21, 2026 00:13
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
meteredNetworkAwareinline-completion provider metadata, defaulting tofalse; providers opt in when they are local-only or handle metered connections themselvesFixes #297407
Fixes #297412