This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Support for multiple selections - #7
Open
Hugo Migneron (hmigneron) wants to merge 5 commits into
Open
Conversation
This also addresses the issue of the wrong selection after wrapping an empty selection Progress on microsoft#6
…h Travis tests on linux.
Author
|
Will anyone be able to review this ? Brad Gashler (@bgashler1) ? |
Contributor
|
Thanks Hugo Migneron (@hmigneron) for your contribution. I'll be taking a look. |
Contributor
|
This issue was moved to bgashler1/vscode-htmltagwrap#10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for multiple selections.
Multiple selections work the same way single ones do : inline tag wrap is supported as well as multiline "block" tag wrap. We can also have a mix of the two.
The pull request also addresses the bug with empty selections (#6) which are now supported (both with single or multiple selections).
Thank you !