Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"changes": [
{
"packageName": "@rushstack/eslint-plugin",
"comment": "Fix no-new-null false positives for ECMAScript private class members.",
"type": "patch"
}
]
}
9 changes: 7 additions & 2 deletions eslint/eslint-plugin/src/no-new-null.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ type Options = [];

interface IAccessible {
accessibility?: TSESTree.Accessibility;
key?: TSESTree.Node;
}

const noNewNullRule: TSESLint.RuleModule<MessageIds, Options> = {
Expand Down Expand Up @@ -37,11 +38,15 @@ const noNewNullRule: TSESLint.RuleModule<MessageIds, Options> = {

create: (context: TSESLint.RuleContext<MessageIds, Options>) => {
/**
* Returns true if the accessibility is not explicitly set to private or protected, e.g. class properties, methods.
* Returns true unless a class member uses protected, TypeScript-private, or ECMAScript-private syntax.
*/
function isPubliclyAccessible(node?: IAccessible): boolean {
const accessibility: TSESTree.Accessibility | undefined = node?.accessibility;
return !(accessibility === 'private' || accessibility === 'protected');
return (
accessibility !== 'private' &&
accessibility !== 'protected' &&
node?.key?.type !== AST_NODE_TYPES.PrivateIdentifier
);
}

/**
Expand Down
11 changes: 11 additions & 0 deletions eslint/eslint-plugin/src/test/no-new-null.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,17 @@ ruleTester.run('no-new-null', noNewNullRule, {
' }',
'}'
].join('\n')
},
{
code: [
'class NativePrivateNulls {',
' #field: string | null;',
' #propertyFunc: (value: string | null) => void;',
' #method(value: string | null): string | null { return value; }',
' get #value(): string | null { return this.#field; }',
' set #value(value: string | null) { this.#field = value; }',
'}'
].join('\n')
}
]
});