chore: add support for macos platform key in autolinking config#2995
Open
gabrieldonadel wants to merge 1 commit into
Open
chore: add support for macos platform key in autolinking config#2995gabrieldonadel wants to merge 1 commit into
gabrieldonadel wants to merge 1 commit into
Conversation
Saadnajmi
approved these changes
Jun 24, 2026
shirakaba
approved these changes
Jun 25, 2026
shirakaba
left a comment
shirakaba
left a comment
There was a problem hiding this comment.
Looks like an improvement, just a forward-facing question from me.
| packages = config["dependencies"] | ||
| ios_project_root = Pathname.new(config["project"]["ios"]["sourceDir"]) | ||
| project_config = config["project"]["macos"] || config["project"]["ios"] # [macOS] | ||
| ios_project_root = Pathname.new(project_config["sourceDir"]) # [macOS] |
There was a problem hiding this comment.
Would it be beneficial to divide this into ios_project_root and macos_project_root (and add macos_project_root to the return value)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The CocoaPods autolinking script hard-codes the
iosplatform key when reading thereact-native configJSON, which assumes the upstream config provider always emits its project root and per-package config underios. For proper out-of-tree platform support, autolinking should honor--platform macosand readpackage["platforms"]["macos"], otherwiseconfig["project"]["ios"]isnilandpod installcrashes.Test Plan:
pod installin areact-native-macostest app driven by Expo's CLI (expo-modules-autolinkingwith--platform macos) completes without thenil:NilClasserror onconfig["project"]["ios"].pod installin areact-native-macostest app driven by@react-native-community/cli(which emitsioskeys) still resolves the same set of pods as before.platforms.iosin theirreact-native.config.jsstill appear inFound N modules for target ....