fix(screencast): register AnnotatePosition enum serializer#1948
Open
Develop-KIM wants to merge 1 commit into
Open
fix(screencast): register AnnotatePosition enum serializer#1948Develop-KIM wants to merge 1 commit into
Develop-KIM wants to merge 1 commit into
Conversation
AnnotatePosition had no Gson serializer registered, so Screencast.showActions() sent the raw enum constant (e.g. TOP_RIGHT) to the driver, which rejected it with "position: expected one of (top-left|top|top-right|...)". Register it with ToLowerCaseAndDashSerializer so values serialize as top-right, matching the other dashed enums. Fixes: microsoft#1912
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AnnotatePositionhad no Gson serializer registered, sopage.screencast().showActions(new Screencast.ShowActionsOptions().setPosition(AnnotatePosition.TOP_RIGHT))sent the raw constantTOP_RIGHTto the driver, which rejected it:position: expected one of (top-left|top|top-right|...).ToLowerCaseAndDashSerializer(as used forColorScheme,ServiceWorkerPolicy, …) so values serialize astop-rightetc.Fixes #1912