feat: add Automatic-Module-Name manifest entries#1947
Open
raphw wants to merge 1 commit into
Open
Conversation
Give the published jars stable Java module names so they can be required from the module path instead of relying on filename-derived automatic names: - playwright: com.microsoft.playwright - driver: com.microsoft.playwright.driver - driver-bundle: com.microsoft.playwright.driver.bundle The playwright test-jar carries its own name (com.microsoft.playwright.test) so the main jar and the test-jar never claim the same module.
Author
|
@microsoft-github-policy-service agree |
Member
|
What practical issue does it solve? |
yury-s
approved these changes
Jul 9, 2026
Author
|
It avoids that Playwright depends on file names when you use Java's module system and want to use Playwright from this application. Right now two modular applications might choose different names and become incompatible if they choose different file names and therefore module names. If Playwright makes this choice it provides a stable name for consumption. Also, some tooling requires a module name at least on the manifest level. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Give the published jars stable Java module names so they can be required from the module path instead of relying on filename-derived automatic names:
The playwright test-jar carries its own name
(com.microsoft.playwright.test) so the main jar and the test-jar never claim the same module.