Skip GQA key/value repeat when query and key head counts are equal#2957
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix CI errors with torch-nightly
Skip GQA key/value repeat when query and key head counts are equal
Jul 8, 2026
titaiwangms
approved these changes
Jul 8, 2026
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
View the full list of 2 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
torch-nightly now passes
enable_gqa=Truetoscaled_dot_product_attentioneven when the number of query heads equals the number of key/value heads, tripping the assertion in_attention_repeat_kv_for_group_query(q_num_heads > kv_num_heads) and failing the torch_lib tests in CI.Change
aten_scaled_dot_product_attention(onnxscript/function_libs/torch_lib/ops/nn.py): gate the group-query key/value expansion on an actual head-count mismatch, so equal-head inputs bypass the repeat (a no-op) instead of hitting the assertion.