UefiTestingPkg: Allow DxePagingAuditTestApp to be renamed - #927
Merged
Conversation
Contributor
⏩ QEMU Validation SkippedThe PR was merged before validation completed. This comment was automatically generated by the Mu QEMU PR Validation workflow. |
kuqin12
approved these changes
Jul 24, 2026
apop5
reviewed
Jul 24, 2026
apop5
approved these changes
Jul 24, 2026
Currently, if the application file name is changed or it is placed in a non-root directory, an assert occurs with no console-visible output. This change locates the SFS protocol on the device handle instead of iterating across all SFS protocols to locate an instance with a file present that matches the hardcoded application file name. It also closes the SFS handle after dumping the paging info, which was previously left open. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
makubacki
force-pushed
the
926_name_loc_fix
branch
from
July 27, 2026 21:05
13bb9aa to
4678fa4
Compare
makubacki
enabled auto-merge (squash)
July 27, 2026 21:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #926
Currently, if the application file name is changed or it is placed in a non-root directory, an assert occurs with no console-visible output.
This change locates the SFS protocol on the device handle instead of iterating across all SFS protocols to locate an instance with a file present that matches the hardcoded application file name.
It also closes the SFS handle after dumping the paging info, which was previously left open.
How This Was Tested
Run
DxePagingAuditTestApp.efi -rRun
DxePagingAuditTestApp.efi -dfrom the volume root (FS0:)Run
DxePagingAuditTestApp.efi -dfrom a subdirecotry (e.g./somedir)Verify files are written in the same directory as the application and it does not assert.
Integration Instructions
There are some style and miscellaneous changes unrelated to this functional change I might make in a future PR, but I didn't do so here to avoid scope creep.
OpenVolumeSFS()which does a more generic search.