Revert "[release-branch.go1.25] Ship .asc signature alongside .sig"#2415
Open
dagood wants to merge 1 commit into
Open
Revert "[release-branch.go1.25] Ship .asc signature alongside .sig"#2415dagood wants to merge 1 commit into
dagood wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts the previous change that produced an additional .asc signature artifact alongside the existing .sig for signed release archives, bringing the signing output back in line with the pre-#2404 behavior in the release branch.
Changes:
- Stop copying the generated
.sigsignature to an additional.ascfile in the destination directory. - Update the inline comment describing how the
.sigsigning flow works.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #2404