[release-branch.go1.26] Ship .asc signature alongside .sig#2403
Open
gdams wants to merge 2 commits into
Open
Conversation
Produce an .asc PGP signature file alongside the existing .sig for every tar.gz archive. The .sig remains the default/primary extension; .asc is shipped in parallel for compatibility with upstream Go tooling (e.g. official Dockerfiles). Fixes #181
Co-authored-by: Davis Goodin <dagood@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Backports the signing tool change to ship an additional .asc signature file alongside the existing .sig for each signed archive, improving compatibility with upstream Go consumption tooling while keeping .sig as the primary signature output.
Changes:
- Clarifies the in-code explanation of how
.sigfiles are generated during signing. - Copies the generated
.sigsignature to the destination directory twice: once as.sigand once as.asc(same content).
Show a summary per file
| File | Description |
|---|---|
| eng/_util/cmd/sign/archive.go | Produces an additional .asc signature artifact in the output directory alongside the existing .sig. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #2348