Update FIPS user guide#2393
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the FIPS user guide (eng/doc/fips/UserGuide.md) to document additional crypto APIs (HKDF, ML-DSA, ML-KEM, SHA-3 family) and clarify TLS behavior in newer Go versions.
Changes:
- Added new sections documenting
crypto/hkdf,crypto/mldsa,crypto/mlkem, andcrypto/sha3backend support details. - Expanded the TLS guidance to describe Microsoft-recommended TLS defaults and additional FIPS-mode key exchange groups.
- Updated the document’s TOC and reference links to include the newly documented functions/APIs.
Member
|
Probably worth waiting and reapplying this on top of the structure added by |
Member
|
About waiting for #2394: I'm fine with going ahead here and reconciling the other way, my thought is just that it might be easier to review the changes without markdown formatting being a factor. |
Member
Add the crypto/sha3, crypto/hkdf, crypto/pbkdf2, crypto/mlkem, and crypto/mldsa sections to the FIPS User Guide and refresh the crypto/tls section (ML-KEM key exchange groups, updated FIPS cipher suites, ChaCha20-Poly1305 note, and the ms_tlsprofile/ms_tlsx25519 GODEBUG settings). Authored in the updatecryptodocs generator and regenerated.
michelle-clayton-work
force-pushed
the
dev/mclayton/bump-darwin-sha3
branch
from
782e066 to
dfbaa3a
Compare
gdams
approved these changes
Jul 7, 2026
dagood
approved these changes
Jul 7, 2026
dagood
left a comment
dagood
left a comment
Member
There was a problem hiding this comment.
LGTM! I didn't review every specific note for correctness (not super up to speed on crypto backend changes) but nothing stood out to me, and it can be fixed later if necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing functions to guide
closes: https://github.com/microsoft/go-lab/issues/459