Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Unreleased
- Change the default large payload externalization threshold (`LargePayloadStorageOptions.ThresholdBytes`) from 900,000 bytes to 256 KiB (262,144 bytes)


## v1.25.0-preview.2
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ namespace Microsoft.DurableTask;
/// </summary>
public sealed class LargePayloadStorageOptions
{
int thresholdBytes = 900_000;
int thresholdBytes = 256 * 1024;

/// <summary>
/// Initializes a new instance of the <see cref="LargePayloadStorageOptions"/> class.
Expand Down Expand Up @@ -60,7 +60,7 @@ public LargePayloadStorageOptions(Uri accountUri, TokenCredential credential)
}

/// <summary>
/// Gets or sets the threshold in bytes at which payloads are externalized. Default is 900_000 bytes.
/// Gets or sets the threshold in bytes at which payloads are externalized. Default is 256 KiB (262,144 bytes).
/// Value must not exceed 1 MiB (1,048,576 bytes).
/// </summary>
public int ThresholdBytes
Expand Down
4 changes: 2 additions & 2 deletions test/Grpc.IntegrationTests/LargePayloadStorageOptionsTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,13 @@ public void ThresholdBytes_ExceedsOneMiB_ThrowsArgumentOutOfRange()
}

[Fact]
public void ThresholdBytes_DefaultValue_Is900000()
public void ThresholdBytes_DefaultValue_Is256KiB()
{
// Arrange & Act
LargePayloadStorageOptions options = new();

// Assert
Assert.Equal(900_000, options.ThresholdBytes);
Assert.Equal(256 * 1024, options.ThresholdBytes);
}

[Fact]
Expand Down
Loading