Fix conda namespace#1840
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects the CondaLockComponentDetector namespace so it aligns with the conda-lock detector’s intended naming, avoiding the incorrect Detectors.Poetry namespace for conda-lock code.
Changes:
- Updated
CondaLockComponentDetectorto useMicrosoft.ComponentDetection.Detectors.CondaLock. - Removed an unnecessary
using Microsoft.ComponentDetection.Detectors.CondaLock;after moving the type into that namespace.
Show a summary per file
| File | Description |
|---|---|
| src/Microsoft.ComponentDetection.Detectors/conda/CondaLockComponentDetector.cs | Renames the detector’s namespace to Detectors.CondaLock and removes a redundant using. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Low
ryanbrandenburg
force-pushed
the
rybrande/conda_namespace
branch
from
d5e84af to
122ef3b
Compare
|
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
ryanbrandenburg
force-pushed
the
rybrande/conda_namespace
branch
from
122ef3b to
db816fc
Compare
grvillic
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This namespace did not match the folder structure or code intention, so I figured I'd clean it up.